From owner-cvs-src@FreeBSD.ORG Wed May 16 09:29:17 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 565DE16A404; Wed, 16 May 2007 09:29:17 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 0964113C44B; Wed, 16 May 2007 09:29:16 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5FC6A.dip.t-dialin.net [84.165.252.106]) by redbull.bpaserver.net (Postfix) with ESMTP id 4AEF42E24E; Wed, 16 May 2007 11:29:10 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 8B8B85B48A3; Wed, 16 May 2007 11:28:54 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l4G9Ss3l023183; Wed, 16 May 2007 11:28:54 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 16 May 2007 11:28:54 +0200 Message-ID: <20070516112854.wz570hty7kss48sc@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 16 May 2007 11:28:54 +0200 From: Alexander Leidinger To: Dag-Erling =?utf-8?b?U23Dg8K4cmdyYXY=?= References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> <861whiy5ra.fsf@dwp.des.no> <20070516094330.dkp2e41vdc0w8kg8@webmail.leidinger.net> <86zm45goph.fsf@dwp.des.no> In-Reply-To: <86zm45goph.fsf@dwp.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.564, required 8, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14, MIME_8BIT_HEADER 0.30) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2007 09:29:17 -0000 Quoting Dag-Erling Sm=C3=83=C2=B8rgrav (from Wed, 16 May 2007 = =20 10:25:14 +0200): > Alexander Leidinger writes: >> Dag-Erling Sm=C3=B8rgrav writes: >> > Alexander Leidinger writes: >> > > The original code hat it before, but you CD into DESTDIR, so it is no= t >> > > necessary anymore. >> > Unless someone goofs and adds an absolute path to ObsoleteFiles.inc... >> > which is why I very deliberately left "${DESTDIR}/" in front of the pat= h >> > in the rm command, although I could probably replace it with "./". >> That would make it more consistent. > > No, wait, there is another reason I had forgotten: the path passed to rm > is shown to the user, so it should be the full path. Ah, yes... ok, why not remove the cd DESTDIR and use DESTDIR instead =20 of the ./? Or add a comment explaining why DESTDIR is used for the rm. Bye, Alexander. --=20 Bombeck's Rule of Medicine: =09Never go to a doctor whose office plants have died. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137