From owner-svn-doc-all@FreeBSD.ORG Fri Jun 7 22:50:54 2013 Return-Path: Delivered-To: svn-doc-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9781A190 for ; Fri, 7 Jun 2013 22:50:54 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by mx1.freebsd.org (Postfix) with ESMTP id 5AEA7191B for ; Fri, 7 Jun 2013 22:50:54 +0000 (UTC) Received: by mail-pd0-f169.google.com with SMTP id y10so5372914pdj.14 for ; Fri, 07 Jun 2013 15:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=69VrgFuV9M1iJ7ZLGfwcbV3XOl7jCcZoBYcVrsDNoGc=; b=t9waL8fhtET43bd1h13/3fnEj8PKLCspLp2vjPdGHRKuPtief6avXls6f/03OH9nfg yxZxbe1ww5vzepfPTNxYMqQ4CdKvSH2LhHlFm2SnPj7Z4vJmglKeOaRQPmdWWkD92GW5 x1aYcZwaFtKDJlwuTz0XEDBjNkYqTHWhFRM/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=69VrgFuV9M1iJ7ZLGfwcbV3XOl7jCcZoBYcVrsDNoGc=; b=H8k/M55cgN4mAvkSkMLgpLFDkrf5pHrBfz3LNKqztYiXkxEPlQbrs4XUC20RRm9aHH WdlT6XC6NF2on+h2agtRMP4j5dju6oq2fRm/0vLhyQWZP+8R8pCqf8DnT7sT3PfbdWfp xbWqARGeqETBkc1Qj3+wuD5LX+cR8ybW01Uv5qYSIJuK/Jtd15XHnYN3CdWP/znbAxOy e4conEJjq4xwICDLpl+MzVGq4jfn/rZWUevD+x/0kQyHG4Ox2p4u03OL5JZM+Jun1nfF sSI34wtC7UwApl8VdiwC93fVhM1/Yrbkyvz86+WblXM5iP7AXPwJoYHphEHJBQW23xJQ qnkA== X-Received: by 10.68.213.231 with SMTP id nv7mr825347pbc.70.1370645448084; Fri, 07 Jun 2013 15:50:48 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.70.45.33 with HTTP; Fri, 7 Jun 2013 15:50:18 -0700 (PDT) In-Reply-To: <20130608.074746.878470589090500805.hrs@allbsd.org> References: <20130607.092534.356568932887378565.hrs@allbsd.org> <20130607113436.4dc1cbc3.trhodes@FreeBSD.org> <20130608.074746.878470589090500805.hrs@allbsd.org> From: Eitan Adler Date: Sat, 8 Jun 2013 00:50:18 +0200 X-Google-Sender-Auth: GOsWOTcLV6zmm-M5X3IpmtVzTKY Message-ID: Subject: Re: svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js To: Hiroki Sato Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmShdWM0XmxJCCJz/l1dAPQcwk8Iq8yidmBikuYNWtXocfpVXaaNz+R9SxGlstRVsf9nlHe Cc: wblock@wonkity.com, trhodes@freebsd.org, svn-doc-head@freebsd.org, gjb@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org X-BeenThere: svn-doc-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire doc trees \(except for " user" , " projects" , and " translations" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jun 2013 22:50:54 -0000 On 8 June 2013 00:47, Hiroki Sato wrote: > Eitan Adler wrote > in : > > ea> On 7 June 2013 17:34, Tom Rhodes wrote: > ea> > On Fri, 07 Jun 2013 09:25:34 +0900 (JST) > ea> > Hiroki Sato wrote: > ea> > > ea> >> Eitan Adler wrote > ea> >> in : > ea> >> > ea> >> ea> On 6 June 2013 16:28, Hiroki Sato wrote: > ea> >> ea> > > ea> >> ea> > null, "", and undefined are evaluated as false in Javascript. > ea> >> ea> > > ea> >> ea> Javascript has an odd concept of true and false: > ea> >> ea> null, an empty string, +0, -0, and NaN, and false are the 'false' values. > ea> >> ea> > ea> >> ea> An object will return true. > ea> >> > ea> >> I see. I am not familiar with DNT implementation, but is there a www > ea> >> browser to define navigator.doNotTrack as the value "false"? > ea> >> > ea> >> If so, I think something like the following is needed. > ea> >> > ea> >> var dnt = window.navigator.msDoNotTrack || window.navigator.doNotTrack; > ea> >> var allow_track = (dnt && dnt == 'yes'|| dnt == 1); > ea> >> > ea> >> -- Hiroki > ea> >> > ea> > > ea> > I was assuming based on the discussion that we need to perform > ea> > more than a single check on this, but will this one actually > ea> > work? > ea> > ea> No, after some thoughts I realized that this commit is completely > ea> broken. We must explicitly check for "yes" and "1". This check > ea> basically disabled GA for newer browsers. > > The above code should perform it. Sorry, I was unclear: the version as you explained (checking for existence followed by and explicit "1" or "yes") should be fine. > What is "this check" in your > sentence? The version as committed. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams