From owner-freebsd-ipfw Thu Oct 12 12: 8:24 2000 Delivered-To: freebsd-ipfw@freebsd.org Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (Postfix) with ESMTP id 6583B37B503; Thu, 12 Oct 2000 12:08:20 -0700 (PDT) Received: (from smap@localhost) by whistle.com (8.10.0/8.10.0) id e9CJ8Jw12347; Thu, 12 Oct 2000 12:08:19 -0700 (PDT) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma012341; Thu, 12 Oct 2000 12:08:17 -0700 Received: (from archie@localhost) by bubba.whistle.com (8.11.0/8.11.0) id e9CJ8HR84792; Thu, 12 Oct 2000 12:08:17 -0700 (PDT) (envelope-from archie) From: Archie Cobbs Message-Id: <200010121908.e9CJ8HR84792@bubba.whistle.com> Subject: Re: CFR: patch for bin/18351: ipfw add with no rule number returns the wrong rule number In-Reply-To: <20001012105026.A12636@sunbay.com> "from Ruslan Ermilov at Oct 12, 2000 10:50:26 am" To: Ruslan Ermilov Date: Thu, 12 Oct 2000 12:08:17 -0700 (PDT) Cc: luigi@FreeBSD.ORG, ipfw@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL82 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-ipfw@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Ruslan Ermilov writes: > > I think instead of overloading 'get' (and breaking all user-land > > programs that do 'set') a better approach would be to add a new > > sockopt IP_FW_RULENUM that would retrieve the previously used > > 'automatic' rule number. This would be backward compatible and > > also more intuitive. > > > I instead have decided to allow for IP_FW_ADD to be used in both > setsockopt(2) and getsockopt(2). In setsockopt() case we behave > like it was before. In getsockopt() case we additionally return > the rule back into userland, and it is backwards compatible. OK, that sounds fine to me. > > > Do I need to bump the __FreeBSD_version or not? > > > > In any case, YES. > > Don't you think that 420000 would be appropriate in this case, > assuming I will MFC this before 4.2-RELEASE? I don't think you can do that.. only Jordan should. You can only increase the "minor number", eg., update it from 500012 to 500013 or 411000 to 411001. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ipfw" in the body of the message