From owner-cvs-ports@FreeBSD.ORG Wed Sep 14 04:35:39 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8078B1065670; Wed, 14 Sep 2011 04:35:39 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id CA55A8FC0C; Wed, 14 Sep 2011 04:35:38 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from ) id 1R3hCB-0008Bm-Pg; Wed, 14 Sep 2011 08:35:35 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id DCBA8B84D; Wed, 14 Sep 2011 08:35:34 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id BD404B823; Wed, 14 Sep 2011 08:35:34 +0400 (MSD) Date: Wed, 14 Sep 2011 08:35:34 +0400 From: Dmitry Marakasov To: Raphael Kubo da Costa , avilla@FreeBSD.org, makc@FreeBSD.org Message-ID: <20110914043534.GB28842@hades.panopticon> References: <201109110204.p8B249VK030457@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201109110204.p8B249VK030457@repoman.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.cmake.mk ports/devel/cmake Makefile ports/devel/cmake/files patch-Modules_Compiler_GNU.cmake X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2011 04:35:39 -0000 * Raphael Kubo da Costa (rakuco@FreeBSD.org) wrote: > - Pass default build flags (at least I hope) via bsd.cmake.mk. That's not the best solution as it leads to cmake warnings: --- CMake Warning: The variable, 'CMAKE_CXX_FLAGS_DEBUG', specified manually, was not used during the generation. CMake Warning: The variable, 'CMAKE_C_FLAGS_DEBUG', specified manually, was not used during the generation. CMake Warning: The variable, 'CMAKE_C_FLAGS_RELEASE', specified manually, was not used during the generation. --- However, I've just ran into a variable that should solve the thing gracefully: CMAKE_NOT_USING_CONFIG_FLAGS(=YES) Even better, it affects all other configurations (RELWITHDEBINFO, MINSIZEREL) and other variables (at least CMAKE_*_LINKER_FLAGS). Quick testing shows that there are neiter foreign flags nor warnings in the logs. Patch: --- bsd.cmake.mk.patch begins here --- Index: bsd.cmake.mk =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.cmake.mk,v retrieving revision 1.10 diff -u -r1.10 bsd.cmake.mk --- bsd.cmake.mk 11 Sep 2011 02:04:08 -0000 1.10 +++ bsd.cmake.mk 14 Sep 2011 04:27:17 -0000 @@ -53,14 +53,11 @@ CMAKE_ARGS+= -DCMAKE_C_COMPILER:STRING="${CC}" \ -DCMAKE_CXX_COMPILER:STRING="${CXX}" \ -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ - -DCMAKE_C_FLAGS_DEBUG:STRING="${CFLAGS}" \ - -DCMAKE_C_FLAGS_RELEASE:STRING="${CFLAGS}" \ -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \ - -DCMAKE_CXX_FLAGS_DEBUG:STRING="${CXXFLAGS}" \ - -DCMAKE_CXX_FLAGS_RELEASE:STRING="${CXXFLAGS}" \ -DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \ -DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \ - -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES + -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES \ + -DCMAKE_NOT_USING_CONFIG_FLAGS:BOOL=TRUE # # Default build type and sourcedir --- bsd.cmake.mk.patch ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru