From owner-svn-src-all@FreeBSD.ORG  Mon May 18 14:04:29 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7ACBFB29
 for <svn-src-all@freebsd.org>; Mon, 18 May 2015 14:04:29 +0000 (UTC)
Received: from outbound3.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119]) by mx1.freebsd.org (Postfix) with SMTP id 4CCC21CE9
 for <svn-src-all@freebsd.org>; Mon, 18 May 2015 14:04:29 +0000 (UTC)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Mon, 18 May 2015 14:04:18 +0000 (UTC)
Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id t4IE4OeM014550;
 Mon, 18 May 2015 08:04:26 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1431957864.91685.57.camel@freebsd.org>
Subject: Re: svn commit: r282985 - in head/sys: arm/annapurna
 arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm
From: Ian Lepore <ian@freebsd.org>
To: Mathieu Arnold <m@absolight.fr>
Cc: Eitan Adler <eadler@freebsd.org>, phabric-admin@freebsd.org, Garrett
 Cooper <yaneurabeya@gmail.com>, Adrian Chadd <adrian@freebsd.org>, Zbigniew
 Bodek <zbb@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Mon, 18 May 2015 08:04:24 -0600
In-Reply-To: <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc>
References: <201505151825.t4FIPnxJ099637@svn.freebsd.org>
 <CAJ-Vmomw3QeX4QfwN3ZH+cgJGbcJJT0LyjF8d+2EX0vExQzYog@mail.gmail.com>
 <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com>
 <1431877581.91685.49.camel@freebsd.org>
 <CAF6rxg=kNFBhDWY0VZKWUb=sVRc-XRtJVGOquEAX=jcdq_CkYA@mail.gmail.com>
 <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 14:04:29 -0000

On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote:
> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler <eadler@freebsd.org> wrote:
> | On 17 May 2015 at 08:46, Ian Lepore <ian@freebsd.org> wrote:
> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote:
> |>> > On May 16, 2015, at 18:45, Adrian Chadd <adrian@freebsd.org> wrote:
> |>> > 
> |>> > Did you commit files with DOS newlines in them? :)
> |>> > 
> |>> > tsk tsk tsk tsk tsk. I think should fix that..
> |>> 
> |>> Better yet it should probably be disabled in svn...
> |>> 
> |> 
> |> Or flagged by some filter as a diff is uploaded to phabricator, since
> |> the web display obscures whitespace.
> | 
> | This is possible.  Would blocking all diffs that match /\r\n$/ work?
> 
> That would crap up all patches that match that, which is a bad idea.
> 

Why would that be a bad idea?  Do we have files in the system that
legitimately end with MSDOS line endings that need to be preserved as
such?

I'm not sure blocking is the right thing anyway, it would be better if
it was like a warning dialog..."The diff you just uploaded contains DOS
line endings, continue?"

-- Ian