From owner-freebsd-current Sat Dec 23 0: 0:25 2000 From owner-freebsd-current@FreeBSD.ORG Sat Dec 23 00:00:21 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from earth.backplane.com (placeholder-dcat-1076843399.broadbandoffice.net [64.47.83.135]) by hub.freebsd.org (Postfix) with ESMTP id 7FA5A37B400; Sat, 23 Dec 2000 00:00:21 -0800 (PST) Received: (from dillon@localhost) by earth.backplane.com (8.11.1/8.9.3) id eBN80Le93546; Sat, 23 Dec 2000 00:00:21 -0800 (PST) (envelope-from dillon) Date: Sat, 23 Dec 2000 00:00:21 -0800 (PST) From: Matt Dillon Message-Id: <200012230800.eBN80Le93546@earth.backplane.com> To: Assar Westerlund Cc: mjacob@feral.com, current@FreeBSD.ORG Subject: Re: is it possible to have a NULL procp for an NFS request? References: <5lu27vlgz0.fsf@assaris.sics.se> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :Matthew Jacob writes: :> Hmm. The client wasn't following symlinks. : :You sure? What happens is when you queue up an nfs operation provoked :by following a symlink. I couldn't figure any other way of making :that happen. : :> The patch seems simple enough, but it probably shouldn't just :> swallow the error. : :Yeah, your patch to subr_prf.c is better. : :/assar Looking at the cvs logs it looks like Poul forgot to check for p == NULL in his new simplified tprintf() API. The 'sess' based tprintf did check for NULL. The proc based tprintf does not. So fixing it in tprintf() itself, in subr_prf.c, is the right move. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message