From owner-cvs-all@FreeBSD.ORG  Tue Feb  3 04:24:50 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F3F7216A4CE; Tue,  3 Feb 2004 04:24:49 -0800 (PST)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0D7B643D31; Tue,  3 Feb 2004 04:24:48 -0800 (PST)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 7439E65449; Tue,  3 Feb 2004 12:24:46 +0000 (GMT)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 38705-01-12; Tue,  3 Feb 2004 12:24:46 +0000 (GMT)
Received: from saboteur.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com
	[82.147.17.88])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 9500F65444; Tue,  3 Feb 2004 12:24:44 +0000 (GMT)
Received: by saboteur.dek.spc.org (Postfix, from userid 1001)
	id AA19FB9; Tue,  3 Feb 2004 12:24:36 +0000 (GMT)
Date: Tue, 3 Feb 2004 12:24:36 +0000
From: Bruce M Simpson <bms@spc.org>
To: Brooks Davis <brooks@one-eyed-alien.net>
Message-ID: <20040203122436.GE713@saboteur.dek.spc.org>
Mail-Followup-To: Brooks Davis <brooks@one-eyed-alien.net>,
	Andre Oppermann <andre@freebsd.org>, src-committers@freebsd.org,
	cvs-src@freebsd.org, cvs-all@freebsd.org
References: <200402022253.i12MrGkO091411@repoman.freebsd.org>
	<20040202232614.GA24019@Odin.AC.HMC.Edu> <401EE109.D45B606@freebsd.org>
	<20040203000622.GA19568@Odin.AC.HMC.Edu>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS"
Content-Disposition: inline
In-Reply-To: <20040203000622.GA19568@Odin.AC.HMC.Edu>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: Andre Oppermann <andre@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netinet ip_icmp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 12:24:50 -0000


--qMm9M+Fa2AknHoGS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 02, 2004 at 04:06:22PM -0800, Brooks Davis wrote:
> I'm not sugguesting caching the ifp.  I'm suggesting storing the value
> of ifp->if_index.  You then use ifnet_byindex to get then the ifp when
> needed.  You have to check that it isn't NULL, but you should to be
> doing that for the ifunit() call as well since it will return NULL and
> cause a panic if the admin makes a typo.

Good catch. Thanks.

BMS

--qMm9M+Fa2AknHoGS
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Comment: ''

iD8DBQFAH5MDueUpAYYNtTsRApuAAJ9r4ajOXPKrcWhhY+hNTG1gMhu9vACeL0iG
wehT8lDagPRUjrg8n0T5PzA=
=iJ77
-----END PGP SIGNATURE-----

--qMm9M+Fa2AknHoGS--