From owner-freebsd-apache@FreeBSD.ORG Sat Jul 19 16:07:47 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31A84CF5 for ; Sat, 19 Jul 2014 16:07:47 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BEC332750 for ; Sat, 19 Jul 2014 16:07:46 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LomuB-1Wb7120nmt-00goEM; Sat, 19 Jul 2014 18:02:23 +0200 Message-ID: <53CA9694.4040409@gmx.de> Date: Sat, 19 Jul 2014 18:02:28 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kurt Jaeger Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> <20140719151508.GB33102@f10.opsec.eu> In-Reply-To: <20140719151508.GB33102@f10.opsec.eu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wadKBNUD4/wxikfj4gjmWQrvuuGfYLEWJKBtDgFWK2MYmo8+Mr3 j8G0AUsTkqKw1yexBVizy7igCondix7wer+MyCR9z3M1wFH9NhzAdIPuEVmOHa1ToMUOmbh Lu1eVORGBO5heGXxL+aJBvMJHyOd7aHVuxhJ+TJZp17HnUyBfTEdltHDiqgcSwJb4HbU+dO KqW+9hnl01ikTcJEYcg4Q== Cc: Frederic Culot , apache@freebsd.org, skv@FreeBSD.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 16:07:47 -0000 On 2014-07-19 17:15, Kurt Jaeger wrote: > Hello, > >>> Back to my proposed change for www/libapreq2 and this question: >>> >>>>> Would it be more useful to make the slave port (p5-libapreq2) >>>>> a seperate port depending on the other ? >>> >>> Looking at the pkg-plist and Makefile mess: Is it really useful >>> to have this master/slave port or should I split and depend on libapreq2 ? > > Attached are two diffs for both ports that seperate them. > >> running a short grep over the tree shows there are only two libapreq2 consumers >> - www/mod_amazon_proxy >> - www/p5-libapreq2 >> >> but eleven p5-libapreq consumers >> - net-mgmt/netdisco >> - net-mgmt/netdot >> - www/foswiki-ModPerlEngineContrib >> - www/p5-Apache-Gallery >> - www/p5-Apache2-SiteControl >> - www/p5-CGI-Application-Plugin-Apache >> - www/p5-HTML-Mason >> - www/p5-Maypole >> - www/rt38 >> - www/rt40.cpan >> - www/rt42.cpan > > I ran a bulk poudriere run with this: > > www/mod_amazon_proxy > net-mgmt/netdisco > net-mgmt/netdot > www/foswiki-ModPerlEngineContrib > www/p5-Apache-Gallery > www/p5-Apache2-SiteControl > www/p5-CGI-Application-Plugin-Apache > www/p5-HTML-Mason > www/p5-Maypole > www/rt38 > www/rt40 > www/rt42 > > and DEFAULT_VERSIONS=perl5=5.20 apache=2.2 > > without problems on 10amd64 and 91amd64. > > Attached are the two diffs, please comment, and if it's OK, please > approve. > > I'll also update 191161 for testing. > Hi Kurt, seems some files are missing in the p5-libapreq2.diff >From the p5-libapreq2.diff Only in p5-libapreq2: distinfo Only in p5-libapreq2: files Only in p5-libapreq2: pkg-descr Only in p5-libapreq2: pkg-plist Can you shape a svn diff? $ mkdir fix_libapreq $ cd fix_libapreq $ svn checkout --depth empty svn+ssh://svn.freebsd.org/ports/head ports $ cd ports $ svn up --set-depth empty www $ svn up www/libapreq2 www/p5-libapreq2 # apply your patches $ svn diff > my.diff If your test build was OK feel free to commit your patches. -- olli