From owner-cvs-src@FreeBSD.ORG Mon Jun 11 20:39:26 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6704D16A400 for ; Mon, 11 Jun 2007 20:39:26 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id C231C13C465 for ; Mon, 11 Jun 2007 20:39:25 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 93345 invoked from network); 11 Jun 2007 19:53:07 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 11 Jun 2007 19:53:07 -0000 Message-ID: <466DB2FF.9060300@freebsd.org> Date: Mon, 11 Jun 2007 22:39:27 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Sam Leffler References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> In-Reply-To: <466DACD6.4040606@errno.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 20:39:26 -0000 Sam Leffler wrote: > Andre Oppermann wrote: >> andre 2007-06-11 20:08:12 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/net if.h Log: >> Add IFCAP_LRO flag for drivers to announce their TCP Large Receive >> Offload >> capabilities. >> Revision Changes Path >> 1.108 +1 -0 src/sys/net/if.h >> http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 >> >> > There are many offload capabilities defined that are not well thought > out. In particular we do not distinguish between ipv4 and ipv6 for > things like cksum and tso so there's no way to disable individual > features. The ability to tweak LRO is clearly needed and clearly belong > as an ifnet capability but unilateraly deciding this is the wrong approach. We do distinguish between TSO4 and TSO6 since from the beginning. LRO is not hardware dependent but done in software. However it must be handled from inside the drivers RX function. Our software implementation will be IPv4 and IPv6 aware right from the beginning. It is not an unilateral decision if other directly affected developers agree (Drew, Jack). -- Andre