From owner-freebsd-new-bus  Wed Oct  6 17:19:16 1999
Delivered-To: freebsd-new-bus@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id B689814C39; Wed,  6 Oct 1999 17:18:41 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id SAA14289;
	Wed, 6 Oct 1999 18:18:42 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id SAA07555; Wed, 6 Oct 1999 18:18:17 -0600 (MDT)
Message-Id: <199910070018.SAA07555@harmony.village.org>
To: Doug Rabson <dfr@nlsystems.com>
Subject: Re: Question on loading buses 
Cc: new-bus@FreeBSD.ORG, dfr@FreeBSD.ORG
In-reply-to: Your message of "Thu, 07 Oct 1999 00:42:11 BST."
		<Pine.BSF.4.10.9910070039460.571-100000@salmon.nlsystems.com> 
References: <Pine.BSF.4.10.9910070039460.571-100000@salmon.nlsystems.com>  
Date: Wed, 06 Oct 1999 18:18:16 -0600
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-new-bus@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <Pine.BSF.4.10.9910070039460.571-100000@salmon.nlsystems.com> Doug Rabson writes:
: Currently all that happens when a driver is loaded is that the
: BUS_DRIVER_ADDED method of all instances of the parent bus is called.
: There is a generic implementation of BUS_DRIVER_ADDED which calls
: device_probe_and_attach() for any unmatched device instances but the
: parent probably doesn't have this in its method table. Probably
: bus_generic_driver_added() should call DEVICE_IDENTIFY for the new driver
: too.

You mean the following?

Index: subr_bus.c
===================================================================
RCS file: /home/imp/FreeBSD/CVS/src/sys/kern/subr_bus.c,v
retrieving revision 1.42
diff -u -r1.42 subr_bus.c
--- subr_bus.c	1999/09/10 21:11:23	1.42
+++ subr_bus.c	1999/10/07 00:17:46
@@ -1928,6 +1928,7 @@
 	 child; child = TAILQ_NEXT(child, link))
 	if (child->state == DS_NOTPRESENT)
 	    device_probe_and_attach(child);
+    DEVICE_IDENTRIFY(dev);
 }
 
 int


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-new-bus" in the body of the message