From owner-cvs-all@FreeBSD.ORG  Mon Jun 16 01:16:36 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4FB1337B401; Mon, 16 Jun 2003 01:16:36 -0700 (PDT)
Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7FBAE43F3F; Mon, 16 Jun 2003 01:16:35 -0700 (PDT)
	(envelope-from des@ofug.org)
Received: by flood.ping.uio.no (Postfix, from userid 2602)
	id 7737A5310; Mon, 16 Jun 2003 10:16:33 +0200 (CEST)
X-URL: http://www.ofug.org/~des/
X-Disclaimer: The views expressed in this message do not necessarily
  coincide with those of any organisation or company with
  which I am or have been affiliated.
To: Harti Brandt <brandt@fokus.fraunhofer.de>
References: <200306150415.h5F4FTTg032179@repoman.freebsd.org>
	<20030616100333.O7464@beagle.fokus.fraunhofer.de>
From: Dag-Erling Smorgrav <des@ofug.org>
Date: Mon, 16 Jun 2003 10:16:33 +0200
In-Reply-To: <20030616100333.O7464@beagle.fokus.fraunhofer.de> (Harti
 Brandt's message of "Mon, 16 Jun 2003 10:06:25 +0200 (CEST)")
Message-ID: <xzpfzma309q.fsf@flood.ping.uio.no>
User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Warner Losh <imp@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/modules Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jun 2003 08:16:36 -0000

Harti Brandt <brandt@fokus.fraunhofer.de> writes:
> Sorry for that breakage. I should remember: never think a make buildworld
> + make buildkernel for LINT and GENERIC is enough to test a patch!

It should have been enough in this case, the problem seems to be that
you forgot to commit one of the files you modified.

> I'm just making a universe to test the fix (as I usually do).

'make universe' is bad for you, since errors won't interrupt it and
you have to go through the logs manually to figure out what worked and
what didn't.  Take a look at src/tools/tools/tinderbox instead.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org