From owner-cvs-all@FreeBSD.ORG Tue Feb 3 09:15:58 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3DCF116A4CE; Tue, 3 Feb 2004 09:15:58 -0800 (PST) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id D59B043D39; Tue, 3 Feb 2004 09:15:55 -0800 (PST) (envelope-from danfe@regency.nsu.ru) Received: from mail by mx.nsu.ru with drweb-scanned (Exim 3.35 #1 (Debian)) id 1Ao4Mg-0005mm-00; Tue, 03 Feb 2004 23:29:34 +0600 Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 3.35 #1 (Debian)) id 1Ao4Mf-0005mc-00; Tue, 03 Feb 2004 23:29:33 +0600 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.9p2/8.12.9) with ESMTP id i13HGIcU096880; Tue, 3 Feb 2004 23:16:18 +0600 (NOVT) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.9p2/8.12.9/Submit) id i13HGImD096878; Tue, 3 Feb 2004 23:16:18 +0600 (NOVT) (envelope-from danfe) Date: Tue, 3 Feb 2004 23:16:18 +0600 From: Alexey Dokuchaev To: Andre Oppermann Message-ID: <20040203171617.GA87805@regency.nsu.ru> References: <200402030932.i139WBpQ054113@repoman.freebsd.org> <20040203112824.01dfdc99@localhost> <20040203163214.GD17960@electra.cse.Buffalo.EDU> <401FD252.7F56765E@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <401FD252.7F56765E@freebsd.org> User-Agent: Mutt/1.4.1i X-Envelope-To: src-committers@freebsd.org, kensmith@cse.Buffalo.EDU, trhodes@freebsd.org, cvs-src@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, andre@freebsd.org cc: Tom Rhodes cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: Ruslan Ermilov cc: Ken Smith Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 17:15:58 -0000 On Tue, Feb 03, 2004 at 05:54:42PM +0100, Andre Oppermann wrote: > Ken Smith wrote: > > > > On Tue, Feb 03, 2004 at 11:28:24AM -0500, Tom Rhodes wrote: > > > On Tue, 3 Feb 2004 01:32:11 -0800 (PST) > > > Ruslan Ermilov wrote: > > > > > > > bland 2004/02/03 01:32:11 PST > > > ^^^^^ > > > > > > You're bland... :) > > > > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > kerberos5/lib/libroken Makefile > > > > Log: > > > > Take signal.c out of sources. > > > > > > > > Reviewed by: nectar > > > > > > Any idea what is causing this yet? Perhaps I missed/overlooked/ignored > > > the discussion? > > > > > > -- > > > Tom Rhodes > > > > We're actively trying to track it down now. No ETA on it being fixed > > at this point, it is probably buried deep inside some perl scripts > > but that's just a guess. We have caught the last couple of examples > > to help try and track it down though (two or three have happened in > > the last two or three days). > > All this magic happens in CVSROOT-src/cfg.pm where $PID for temporary > files and $COMMITTER are set. $PID is probably not the problem but > $COMMITTER seems to be. The text in this variable is put verbatim into > the commit message in CVSROOT-src/log_accum.pl function build_header(). > > I'm not a perl hacker so I can't really comment on the code snipped > below but it looks strange that the first $ENV{} has the environment > variable name in "" and the second one in '' quotes. At least it seems It should make no difference in this case (there's nothing to expand in either one). ./danfe > to be inconsistent. I wonder if we ever can get into the case where > LOGNAME and USER are not set in the users environment. It might be > that for some SSH setups the environment is cleared or altered on > freefall. Nontheless I don't think any of the others should return > anything else than the current username. Unless there is a bug in > the kernel wrt credential handling or some other bug in perl. > > # The username of the committer. > $COMMITTER = $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin > || (getpwuid($<))[0] || sprintf("uid#%d",$<); > > > -- > Andre > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"