From owner-cvs-all@FreeBSD.ORG  Tue Feb  3 09:18:55 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2B52616A4CE; Tue,  3 Feb 2004 09:18:55 -0800 (PST)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7705E43D6D; Tue,  3 Feb 2004 09:18:51 -0800 (PST)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id 45DB45309; Tue,  3 Feb 2004 18:18:50 +0100 (CET)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id 9CDF05308; Tue,  3 Feb 2004 18:18:44 +0100 (CET)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 4802933C6A; Tue,  3 Feb 2004 18:18:44 +0100 (CET)
To: Andre Oppermann <andre@freebsd.org>
References: <200402030932.i139WBpQ054113@repoman.freebsd.org>
	<20040203112824.01dfdc99@localhost>
	<20040203163214.GD17960@electra.cse.Buffalo.EDU>
	<401FD252.7F56765E@freebsd.org>
From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=)
Date: Tue, 03 Feb 2004 18:18:44 +0100
In-Reply-To: <401FD252.7F56765E@freebsd.org> (Andre Oppermann's message of
 "Tue, 03 Feb 2004 17:54:42 +0100")
Message-ID: <xzpk7345bez.fsf@dwp.des.no>
User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63
cc: Tom Rhodes <trhodes@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-src@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: Ken Smith <kensmith@cse.Buffalo.EDU>
Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 17:18:55 -0000

Andre Oppermann <andre@freebsd.org> writes:
> I'm not a perl hacker so I can't really comment on the code snipped
> below but it looks strange that the first $ENV{} has the environment
> variable name in "" and the second one in '' quotes.

this has no significance.

>  # The username of the committer.
>  $COMMITTER =3D $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin
>  		|| (getpwuid($<))[0] || sprintf("uid#%d",$<);

This should be

$COMMITTER =3D $ENV{'CVS_USER'} ||
    die("Not invoked by CVS!\n");

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no