From owner-freebsd-current@FreeBSD.ORG Fri Apr 8 12:45:13 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 83975106566C; Fri, 8 Apr 2011 12:45:13 +0000 (UTC) Date: Fri, 8 Apr 2011 12:45:13 +0000 From: Alexander Best To: Garrett Cooper Message-ID: <20110408124513.GA22745@freebsd.org> References: <20110407185510.GA94830@freebsd.org> <20110407212225.GA17091@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2011 12:45:13 -0000 On Thu Apr 7 11, Garrett Cooper wrote: > On Thu, Apr 7, 2011 at 2:22 PM, Alexander Best wrote: > > On Thu Apr  7 11, Garrett Cooper wrote: > >> On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrote: > >> > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wrote: > >> >> hi there, > >> >> > >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let > >> >> tinderbox fail, if any new kernel code was committed with (a) broken include > >> >> dir(s). > >> >> > >> >> i ran a test via > >> >> > >> >> make toolchains > >> >> make MAKE_JUST_KERNELS=yes tinderbox > >> >> > >> >> and nothing seemed to go wrong with the extra warning enabled. i even found a > >> >> missing include dir, which should be fixed by the attached patch. > >> >> > >> >> opinions? > >> >> > >> >> so far i've only tested this with gcc. i think someone on #freebsd-clang told > >> >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). > >> > > >> >    make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf > >> > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these > >> > files, but it doesn't currently)? > > > > otaku% make -f /etc/src.conf -VMODULES_OVERRIDE > > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock > > otaku% make -f /etc/make.conf -VMODULES_OVERRIDE > > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock > > > > ...however i checked and tinderbox *does* ignore src.conf and make.conf. the > > _.* log files show that modules were being build which are not returned by > > the commands above. > > > > i think having this flag would be very useful, because it would force people to > > make sure their include dirs are correct. > > > >> > >> Sorry. Second invocation should have been make.conf, not src.conf. > > Ok then. I stand corrected for not having tested out my claim beforehand. > > Yes, I agree that adding this flag in the default set is a good idea. cool. so now we need somebody to make the commit. ;) > > Thanks, > -Garrett -- a13x