From owner-cvs-all@FreeBSD.ORG  Tue Feb  3 09:31:34 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B69DD16A4CE
	for <cvs-all@freebsd.org>; Tue,  3 Feb 2004 09:31:34 -0800 (PST)
Received: from phantom.cris.net (phantom.cris.net [212.110.130.74])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 643BE43D5F
	for <cvs-all@freebsd.org>; Tue,  3 Feb 2004 09:31:25 -0800 (PST)
	(envelope-from ru@FreeBSD.org.ua)
Received: from phantom.cris.net (ru@localhost [127.0.0.1])
	by phantom.cris.net (8.12.10/8.12.10) with ESMTP id i13HTPem087350;
	Tue, 3 Feb 2004 19:29:28 +0200 (EET)
	(envelope-from ru@FreeBSD.org.ua)
Received: (from ru@localhost)
	by phantom.cris.net (8.12.10/8.12.10/Submit) id i13HTKwX087345;
	Tue, 3 Feb 2004 19:29:21 +0200 (EET)
	(envelope-from ru)
Date: Tue, 3 Feb 2004 19:29:18 +0200
From: Ruslan Ermilov <ru@freebsd.org>
To: Dag-Erling Sm?rgrav <des@des.no>
Message-ID: <20040203172918.GD82507@FreeBSD.org.ua>
References: <200402030932.i139WBpQ054113@repoman.freebsd.org>
	<20040203112824.01dfdc99@localhost>
	<20040203163214.GD17960@electra.cse.Buffalo.EDU>
	<401FD252.7F56765E@freebsd.org> <xzpk7345bez.fsf@dwp.des.no>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="BQPnanjtCNWHyqYD"
Content-Disposition: inline
In-Reply-To: <xzpk7345bez.fsf@dwp.des.no>
User-Agent: Mutt/1.5.5.1i
cc: Tom Rhodes <trhodes@freebsd.org>
cc: src-committers@freebsd.org
cc: Andre Oppermann <andre@freebsd.org>
cc: cvs-src@freebsd.org
cc: cvs-all@freebsd.org
cc: Ken Smith <kensmith@cse.Buffalo.EDU>
Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 17:31:34 -0000


--BQPnanjtCNWHyqYD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 03, 2004 at 06:18:44PM +0100, Dag-Erling Sm?rgrav wrote:
> Andre Oppermann <andre@freebsd.org> writes:
> > I'm not a perl hacker so I can't really comment on the code snipped
> > below but it looks strange that the first $ENV{} has the environment
> > variable name in "" and the second one in '' quotes.
>=20
> this has no significance.
>=20
> >  # The username of the committer.
> >  $COMMITTER =3D $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin
> >  		|| (getpwuid($<))[0] || sprintf("uid#%d",$<);
>=20
> This should be
>=20
> $COMMITTER =3D $ENV{'CVS_USER'} ||
>     die("Not invoked by CVS!\n");
>=20
Isn't CVS_USER defined only in pserver?


Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org

--BQPnanjtCNWHyqYD
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAH9puUkv4P6juNwoRAqHsAJ9D9CGtD4M6NwQEHQDvuJO/lQ2/bwCeJ40m
muXGHIioNH+afEQaVTZ68g0=
=LN4Y
-----END PGP SIGNATURE-----

--BQPnanjtCNWHyqYD--