From owner-cvs-all@FreeBSD.ORG  Tue Feb  3 10:24:24 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 94BD816A4CE; Tue,  3 Feb 2004 10:24:24 -0800 (PST)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7C68B43D1F; Tue,  3 Feb 2004 10:24:22 -0800 (PST)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP
	id 16D8754883; Tue,  3 Feb 2004 12:24:22 -0600 (CST)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id B2E356D455; Tue,  3 Feb 2004 12:24:21 -0600 (CST)
Date: Tue, 3 Feb 2004 12:24:21 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Andre Oppermann <andre@freebsd.org>
Message-ID: <20040203182421.GB80532@madman.celabo.org>
References: <200402030932.i139WBpQ054113@repoman.freebsd.org>
	<20040203112824.01dfdc99@localhost>
	<20040203163214.GD17960@electra.cse.Buffalo.EDU>
	<401FD252.7F56765E@freebsd.org> <401FD43E.174A6839@freebsd.org>
	<20040203170652.GA80415@madman.celabo.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040203170652.GA80415@madman.celabo.org>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.4i-ja.1
cc: Tom Rhodes <trhodes@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-src@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: Ken Smith <kensmith@cse.Buffalo.EDU>
Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 18:24:24 -0000

On Tue, Feb 03, 2004 at 11:06:52AM -0600, Jacques A. Vidrine wrote:
> On Tue, Feb 03, 2004 at 06:02:54PM +0100, Andre Oppermann wrote:
> > Hmm...  getlogin might be the problem (from perl man page):
> > 
> >  getlogin
> > 
> >     Implements the C library function of the same name, which on most systems
> >     returns the current login from /etc/utmp, if any. If null, use getpwuid.
> 
> Only that's not correct for most systems :-)
> 
> getlogin(2) returns what was previously passed to setlogin(2) (usually
> by login(1)).  But this could indeed be a part of the problem,
> especially since there is a known bug in ssh involving a missing
> setsid() ...
> 
> Sorry to tease and run, but I have an appointment right *now*.
> Will follow-up when I return.

No, after reviewing my notes, I don't think it is ssh after all.  In
4.x, an ifdef'd out setsid (sshd.c:1402) leaves sshd subprocesses
[1] sharing the same `struct session' as the master sshd process.
However, the login shell or other commands that are executed will get
their own `struct session', so this is just cosmetic.

Still, I'd recommend removing that `getlogin' invocation.

Cheers,
-- 
Jacques Vidrine   NTT/Verio SME      FreeBSD UNIX       Heimdal
nectar@celabo.org jvidrine@verio.net nectar@freebsd.org nectar@kth.se

[1] The ones that look like `sshd: nectar [priv] (sshd)' and
    `sshd: nectar@notty (sshd)'.