From owner-cvs-all@FreeBSD.ORG Mon Feb 18 17:40:06 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1060) id 012CD16A478; Mon, 18 Feb 2008 17:40:06 +0000 (UTC) Date: Mon, 18 Feb 2008 17:40:05 +0000 From: Craig Rodrigues To: Yar Tikhiy Message-ID: <20080218174005.GA83923@crodrigues.org> References: <200802181024.m1IAOmoF089632@repoman.freebsd.org> <20080218104846.GA81672@crodrigues.org> <20080218142013.GH30694@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080218142013.GH30694@comp.chem.msu.su> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 17:40:06 -0000 On Mon, Feb 18, 2008 at 05:20:14PM +0300, Yar Tikhiy wrote: > This horrible hack is necessary because Someone(tm) started converting > our NFS client to the new nmount(2) semantics a year ago but he has > never finished the job. Now the NFS client just uses old mount(2) Yes, I acknowledge I started this work and did not finish. I have some pending patches to fully convert mount_nfs to pass nmount() string args to the kernel, but I am in the middle of moving, so do not have time to do a lot of FreeBSD work until the end of next week, when I move into my new house. Additionally, touching the NFS mount code is quite involved, so once I am ready to get back to FreeBSD work, I want to circulate the patches a bit more for feedback and testing before committing. >> change and 1.274 to vfs_mount.c out, until we can analyze >> the full implications of your change, and properly fix the >> necessary infrastructure, instead of committing hack after hack? > > Which else _hacks_ did I commit? The mount_nfs hack is the main one that I saw. Can you revert that plus the vfs_mount.c change until we have time to do this right? Some other people already mentioned possible implications of your change to NFS + bootp, which you didn't test. Thanks. -- Craig Rodrigues rodrigc@crodrigues.org