From owner-freebsd-arch@FreeBSD.ORG Wed Jun 8 20:43:05 2005 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61A0816A41C for ; Wed, 8 Jun 2005 20:43:05 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC7C943D1D for ; Wed, 8 Jun 2005 20:43:04 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (localhost [127.0.0.1]) by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id j58Kh3k9082317 for ; Wed, 8 Jun 2005 16:43:03 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.12.10/8.12.10/Submit) with ESMTP id j58Kh36r082312 for ; Wed, 8 Jun 2005 16:43:03 -0400 (EDT) (envelope-from jroberson@chesapeake.net) X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing -bs Date: Wed, 8 Jun 2005 16:43:03 -0400 (EDT) From: Jeff Roberson To: arch@freebsd.org Message-ID: <20050608162637.U16943@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Subject: simplify disksort, please review. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 20:43:05 -0000 http://www.chesapeake.net/~jroberson/disksort.diff Our disksort algorithm used to be complicated by the BIO_ORDERED flag, which could cause us to make some exceptions in the sorting. When the ordered support was removed we never simplified the algorithm. The patch above gets rid of the switch point and associated logic. It's now a simple hinted insertion sort with a one way scan. Since it's a fairly central algorithm, I'd appreciate a review. Cheers, Jeff