From owner-svn-src-all@freebsd.org Sun Aug 14 05:48:39 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBFAFBB9455 for ; Sun, 14 Aug 2016 05:48:39 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 92DE615DD for ; Sun, 14 Aug 2016 05:48:39 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by mail-qk0-x22f.google.com with SMTP id v123so20543562qkh.2 for ; Sat, 13 Aug 2016 22:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Moy1h3uh+zEiyxmzGsPaFIHn0ohNu09AMyAIUGBwj88=; b=d1TH0OICkq/bCc/4IIBXgQHWRgBhsaraY/taxfhduJDRdSGNupZ6iBlGzP1Mvgi8uf WjFQ0PF6dL9fE1GL8ruILmNLjTzJ0b9sKZNz8wsDxYUBf6OddSuegbfkKZjYj6b4jmyF 2eDQAXvjZ8SNPz59sEg5i0MGqZWp/IwnSjLSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Moy1h3uh+zEiyxmzGsPaFIHn0ohNu09AMyAIUGBwj88=; b=nN1TpZnrg6RjDanZcp8PsdsnHDZNmddDcMyBTJbjUjesqayHdZgtnW0ipn8QNqLZVG Thc8vx14AB/7KrcWrhyJFsePMaxcqr4PamgKec/r0Shv2XccNCiEZ0bQsj8zeN7NViNs PEB0t4GtGGurWTgv9969euOqCMiJqBUaSXfcoKIsxHhs3LfMo+GqzVp9/OiKb63lZ1YX inb4U/CcQzH/uHatigw+Vo/JkNF/O31O7NTpsYfPZVa2k62tWO0zu9/b8U/OMO8GaU61 sFv3wYlNFSAS/GQJWqETkTlFZo0OMAQWtRwozDuaA4pW2YvaFGV7l8eBn1CXjc7wefD4 RSpA== X-Gm-Message-State: AEkoouu+QFNBzAH85KH95OVRdZFeDEcHTLUr05t29+H02XYuA/7WYMxyDNON+nYWa2uALW/YR2ttHPe+Db/Xwg== X-Received: by 10.55.5.17 with SMTP id 17mr25420905qkf.280.1471153718522; Sat, 13 Aug 2016 22:48:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.56.105 with HTTP; Sat, 13 Aug 2016 22:48:18 -0700 (PDT) In-Reply-To: <20160814044723.GF11079@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> From: Juli Mallett Date: Sat, 13 Aug 2016 22:48:18 -0700 Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf To: Glen Barber Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 05:48:40 -0000 On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > Quoting the original request to remove this, which I tend to agree: > > -------------------------- begin quoted text --------------------------- > The svn commit mail script uses some form of 'diff -p' (or 'svn diff > -x-p') to include function names at the top of each hunk. The problem > is that diff gets it wrong more often than not, especially (but not > only) when functions are added or renamed, or outside a funciton, or in > headers, or in code that makes heavy use of macros, or in files that > aren't C-like source code: shell scripts, man pages, Makefiles... All > it really does is clutter up the patch and mislead the reader. > --------------------------- end quoted text ---------------------------- :( I'm deeply skeptical that the described conditions add up to "more often than not," and that tangible harm is done in those cases, outweighing benefit added in the other, ostensibly rarer, case (changes in ordinary C source files, which are actually fairly abundant in FreeBSD.) Juli.