From owner-cvs-src@FreeBSD.ORG  Tue Apr 13 19:15:31 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4B22316A4EE; Tue, 13 Apr 2004 19:15:31 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9AB3343D2D; Tue, 13 Apr 2004 19:15:26 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 9C4AB5C7E4; Tue, 13 Apr 2004 19:15:26 -0700 (PDT)
Date: Tue, 13 Apr 2004 19:15:26 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Tim Kientzle <kientzle@FreeBSD.org>
Message-ID: <20040414021526.GB63832@elvis.mu.org>
References: <200404140040.i3E0esil061104@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200404140040.i3E0esil061104@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 02:15:31 -0000

While I applaud the effort here, it is a major violation of C
POLA to have compilable code within a header file.  I think you
should basically move all the variables instantiated in bsdtar.h
to their appropriate .c files.

thank you,
-Alfred

* Tim Kientzle <kientzle@FreeBSD.org> [040413 17:41] wrote:
> kientzle    2004/04/13 17:40:54 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.bin/tar          bsdtar.c bsdtar.h write.c 
>   Log:
>   A simple cache of uid->uname lookups and gid->gname lookups eliminates
>   almost 1/2 of the CPU time required to create an uncompressed archive
>   and makes a noticable reduction in wallclock time.
>   
>   Revision  Changes    Path
>   1.6       +11 -0     src/usr.bin/tar/bsdtar.c
>   1.3       +14 -0     src/usr.bin/tar/bsdtar.h
>   1.7       +35 -12    src/usr.bin/tar/write.c