From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov  9 10:00:45 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 68EA7106566B;
	Mon,  9 Nov 2009 10:00:45 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 292CA8FC16;
	Mon,  9 Nov 2009 10:00:45 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 412496D44C;
	Mon,  9 Nov 2009 10:00:44 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 2531484503; Mon,  9 Nov 2009 11:00:44 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
References: <permail-2009110901223680e26a0b000035b7-a_best01@message-id.uni-muenster.de>
	<87y6mg17y2.fsf@kobe.laptop>
Date: Mon, 09 Nov 2009 11:00:43 +0100
In-Reply-To: <87y6mg17y2.fsf@kobe.laptop> (Giorgos Keramidas's message of
	"Mon, 09 Nov 2009 09:19:33 +0200")
Message-ID: <86hbt4j9v8.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@FreeBSD.org,
	Alexander Best <alexbestms@math.uni-muenster.de>,
	Gabor Kovesdan <gabor@FreeBSD.org>
Subject: Re: [patch] burncd: honour for envar SPEED
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2009 10:00:45 -0000

Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> atoi() doesn't really have error checking and it does not necessarily
> affect `errno'.

man 3 expand_number

And please don't call it SPEED or WRITE_SPEED or anything generic; call
it BURNCD_SPEED or CDROM_BURN_SPEED or something unambiguous.  The envar
used to specify the device is called CDROM, not DEVICE.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no