From owner-svn-ports-head@FreeBSD.ORG  Sat May 25 02:34:27 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 39BB48F2; Sat, 25 May 2013 02:34:27 +0000 (UTC)
Date: Sat, 25 May 2013 02:34:27 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jase Thew <jase@FreeBSD.org>
Subject: Re: svn commit: r318973 - head/irc/weechat
Message-ID: <20130525023427.GB89166@FreeBSD.org>
References: <201305241416.r4OEGl82045133@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201305241416.r4OEGl82045133@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 May 2013 02:34:27 -0000

On Fri, May 24, 2013 at 02:16:47PM +0000, Jase Thew wrote:
> New Revision: 318973
> URL: http://svnweb.freebsd.org/changeset/ports/318973
> 
> -COMMENT=	A lightweight and user friendly ncurse based IRC client
> +COMMENT=	A lightweight and user friendly ncurses based IRC client

Nice catch, but you could've also dropped leading article.

>  BACKTRACE_DESC=	Provide crash backtraces
>  CHARSET_DESC=	Charset conversion support
>  DOCUMENTATION_DESC=	Build and install documentation
> -GUILE_DESC=	Guile scripting support
>  LUA_DESC=	Lua scripting support
>  PERL_DESC=	Perl scripting support
>  PYTHON_DESC=	Python scripting support
>  RUBY_DESC=	Ruby scripting support
>  TCL_DESC=	Tcl scripting support
>  COLOR256_DESC=	Use ncurses port for 256 color support
> +ICON_DESC=	Desktop icon

Better knob description would be "Install desktop icon".

> +.if ${PORT_OPTIONS:MICON}
> +PLIST_SUB+=	ICON=""
> +.else
> +PLIST_SUB+=	ICON="@comment "
> +.endif

Hmm, if all it takes to install in icon is just pkg-plist change (that is,
no extra dependencies), does it really make much sense making it OPTIONal?

./danfe