From owner-cvs-src@FreeBSD.ORG Thu May 1 21:29:17 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 282FE106564A; Thu, 1 May 2008 21:29:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0558F8FC1A; Thu, 1 May 2008 21:29:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id 91C8E1A4D82; Thu, 1 May 2008 14:29:16 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m41LT4NF026442; Thu, 1 May 2008 17:29:04 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Rui Paulo Date: Thu, 1 May 2008 17:28:50 -0400 User-Agent: KMail/1.9.7 References: <200802281910.m1SJAgm1083976@repoman.freebsd.org> <200805011547.07007.jhb@freebsd.org> <481A3406.8080007@FreeBSD.org> In-Reply-To: <481A3406.8080007@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805011728.51152.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 01 May 2008 17:29:04 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7008/Thu May 1 15:52:04 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2008 21:29:17 -0000 On Thursday 01 May 2008 05:20:06 pm Rui Paulo wrote: > John Baldwin wrote: > > On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote: > >> rpaulo 2008-02-28 19:10:42 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/i386/cpufreq est.c > >> Log: > >> Validate the id16 values gathered from ACPI (previously a TODO item). > >> Style changes by me and njl. > > > > What is the purpose of the 'saved_id16' variable? It is never used. I think > > what might be better is to just read it once at the start of the loop and > > then restore it at the end of the loop, though phk@ has overwritten this with > > the "chew up all battery on laptops at all cost" patch. :-P > > > > What do you mean by 'It is never used.' ? > > % cat -n est.c | grep saved_id16 > 1082 uint16_t saved_id16; > 1111 est_get_id16(&saved_id16); Right, it is initialized, but it's value isn't actually _used_ anywhere. There isn't a est_set_id16(&saved_id16), etc. -- John Baldwin