From owner-svn-src-all@FreeBSD.ORG Fri Jan 23 21:12:54 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0A5AE369 for ; Fri, 23 Jan 2015 21:12:54 +0000 (UTC) Received: from o1.l99.sendgrid.net (o1.l99.sendgrid.net [198.37.153.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F18131D for ; Fri, 23 Jan 2015 21:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=4rKD3WRhBFxw+9UBN4m+QDEuo6Q=; b=h4reBvAfPab1ORfZN+ lthwpVoO+kg2zkj8qgS2BrbIATEshQwEhgbgxSqbxXcKYg7MOPVshGvyf3FlxUrG hLHqAXM6xsHKbkxNZE2qJqm2G1VFTEnsyOL4PBKNzxsqnjnjqyEGm4DRjjEM29wH 29izrEASTnPLvnEmGf04QfvVE= Received: by filter0025p1mdw1.sendgrid.net with SMTP id filter0025p1mdw1.14981.54C2B94810 2015-01-23 21:12:49.878434728 +0000 UTC Received: from mail.tarsnap.com (ec2-54-86-246-204.compute-1.amazonaws.com [54.86.246.204]) by ismtpd-009 (SG) with ESMTP id 14b18a3e79a.7f79.42dcc4 for ; Fri, 23 Jan 2015 21:12:49 +0000 (UTC) Received: (qmail 59311 invoked from network); 23 Jan 2015 21:12:13 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 23 Jan 2015 21:12:13 -0000 Received: (qmail 5362 invoked from network); 23 Jan 2015 21:12:01 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 23 Jan 2015 21:12:01 -0000 Message-ID: <54C2B921.3090007@freebsd.org> Date: Fri, 23 Jan 2015 13:12:01 -0800 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Ian Lepore Subject: Re: svn commit: r277606 - head/release References: <201501232024.t0NKODZq079972@svn.freebsd.org> <1422044932.1038.3.camel@freebsd.org> In-Reply-To: <1422044932.1038.3.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SG-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PHNlK6NRk/bdCtK2zayg/4Kq9wcm2oEFOMgCx cUdy6TDj7pLbs46f3qXbYXBYa/b4qApMCgyFR8svFUAELAn8PgUxGH8sHCNKWARnJpJ+9gqzOYxSvr g3KAVsIsjVo65mz8cG/nVAXosqjVD6KU1ijk Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:12:54 -0000 On 01/23/15 12:28, Ian Lepore wrote: > On Fri, 2015-01-23 at 20:24 +0000, Colin Percival wrote: >> release: real-release vm-release cloudware-release >> + @true >> >> real-release: >> ${MAKE} -C ${.CURDIR} ${.MAKEFLAGS} obj >> > > Wouldn't '.PHONY: release' be a better/more-correct fix? Could be. I was inspired by the use of ${DO_NADA} in ports Makefiles, but perhaps that's for targets which truly do nothing rather than targets which serve only to activate their dependencies... if anyone else has opinions on this please email me directly; no point clogging up the mailing list. I'll adjust based on feedback (which is currently leaning in favour of .PHONY). -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid