From owner-svn-ports-head@FreeBSD.ORG  Sat May 25 07:16:32 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E38B41BD;
 Sat, 25 May 2013 07:16:32 +0000 (UTC) (envelope-from bsam@passap.ru)
Received: from forward13.mail.yandex.net (forward13.mail.yandex.net
 [IPv6:2a02:6b8:0:801::3])
 by mx1.freebsd.org (Postfix) with ESMTP id 9AA2326F;
 Sat, 25 May 2013 07:16:32 +0000 (UTC)
Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192])
 by forward13.mail.yandex.net (Yandex) with ESMTP id 884D7141D9D;
 Sat, 25 May 2013 11:16:29 +0400 (MSK)
Received: from smtp14.mail.yandex.net (localhost [127.0.0.1])
 by smtp14.mail.yandex.net (Yandex) with ESMTP id 13DFD1B6064A;
 Sat, 25 May 2013 11:16:29 +0400 (MSK)
Received: from 93.91.2.193.tel.ru (93.91.2.193.tel.ru [93.91.2.193])
 by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTP id uWOK2OVUWb-GSmWdXAD;
 Sat, 25 May 2013 11:16:28 +0400
Message-ID: <51A0654C.4010204@passap.ru>
Date: Sat, 25 May 2013 11:16:28 +0400
From: Boris Samorodov <bsam@passap.ru>
Organization: =?UTF-8?B?0JfQkNCeICLQktCQ0KDQoiI=?=
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
 rv:17.0) Gecko/20130517 Thunderbird/17.0.6
MIME-Version: 1.0
To: Jason Helfman <jgh@FreeBSD.org>
Subject: Re: svn commit: r319003 - head/mail/imaptools
References: <201305241819.r4OIJ4H8030590@svn.freebsd.org>
 <CAMuy=+iSbFNWJee3oJ33i7+ngTKCqeqJdaHKjo87-SuNkZoM5w@mail.gmail.com>
In-Reply-To: <CAMuy=+iSbFNWJee3oJ33i7+ngTKCqeqJdaHKjo87-SuNkZoM5w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Boris Samorodov <bsam@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 May 2013 07:16:33 -0000

25.05.2013 00:59, Jason Helfman пишет:

> Can shebangfix from Mk/Uses be employed here?

Thanks for suggestion, I did not realise that it may be employed
here! However after some invesigation it seems it's not worth,
since a single reinplace command should be replaced by for knobs:
USES+SHEBANG_FILES as well as WRKSRC and NO_BUILD:
-----
Index: Makefile
===================================================================
--- Makefile    (revision 319012)
+++ Makefile    (working copy)
@@ -16,12 +16,12 @@

 CONFLICTS=     imaputils-[0-9]*

+WRKSRC=                ${WRKDIR}
+USES=          shebangfix
+SHEBANG_FILES= *.pl
+NO_BUILD=      yes
 USE_PERL5_RUN= yes

-do-build:
-       ${REINPLACE_CMD} \
-               -e 's|/usr/bin/perl|${PERL}|g' ${WRKDIR}/*.pl
-
 do-install:
        ${INSTALL_SCRIPT} ${WRKDIR}/*.pl ${PREFIX}/bin

-----

What do you think? What benefits are to use the shebangfix here?
-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve