From owner-svn-ports-head@FreeBSD.ORG  Sat May 25 07:33:58 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 12DBD714; Sat, 25 May 2013 07:33:58 +0000 (UTC)
Date: Sat, 25 May 2013 07:33:58 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Boris Samorodov <bsam@passap.ru>
Subject: Re: svn commit: r319003 - head/mail/imaptools
Message-ID: <20130525073358.GA60755@FreeBSD.org>
References: <201305241819.r4OIJ4H8030590@svn.freebsd.org>
 <CAMuy=+iSbFNWJee3oJ33i7+ngTKCqeqJdaHKjo87-SuNkZoM5w@mail.gmail.com>
 <51A0654C.4010204@passap.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51A0654C.4010204@passap.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Jason Helfman <jgh@FreeBSD.org>, Boris Samorodov <bsam@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 May 2013 07:33:58 -0000

On Sat, May 25, 2013 at 11:16:28AM +0400, Boris Samorodov wrote:
> Thanks for suggestion, I did not realise that it may be employed
> here! However after some investigation it seems it's not worth,
> since a single reinplace command should be replaced by for knobs:
> USES+SHEBANG_FILES as well as WRKSRC and NO_BUILD:

It might still be better...

> +WRKSRC=                ${WRKDIR}

Shouldn't NO_WRKSUBDIR be used instead?

> +USES=          shebangfix
> +SHEBANG_FILES= *.pl
> +NO_BUILD=      yes

Having NO_BUILD looks correct: there is, in fact, nothing gets built here.
Hence, it helps to understand port logic better, I think.

Makefile should stary mostly declarative, not imperative.  If one can get
away from manually coding some target actions, and offload the grunt work
to bpm, doesn't it make more sense to just go for it? :-)

./danfe