From owner-freebsd-current@FreeBSD.ORG Mon Jun 14 22:08:16 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7217D106566B for ; Mon, 14 Jun 2010 22:08:16 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.freebsd.org (Postfix) with ESMTP id 05FED8FC19 for ; Mon, 14 Jun 2010 22:08:15 +0000 (UTC) Received: from vampire.homelinux.org (dslb-088-066-005-069.pools.arcor-ip.net [88.66.5.69]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0LaYbD-1P6w770nnD-00luOO; Tue, 15 Jun 2010 00:08:14 +0200 Received: (qmail 84161 invoked from network); 14 Jun 2010 22:08:13 -0000 Received: from f8x64.laiers.local (192.168.4.188) by router.laiers.local with SMTP; 14 Jun 2010 22:08:13 -0000 From: Max Laier Organization: FreeBSD To: freebsd-current@freebsd.org Date: Tue, 15 Jun 2010 00:08:14 +0200 User-Agent: KMail/1.13.3 (FreeBSD/8.0-RELEASE-p2; KDE/4.4.3; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006150008.14124.max@love2party.net> X-Provags-ID: V01U2FsdGVkX18SRmvoCrfg2wdRa8jWx5jEfnEpPYedWn1vbU0 DoVbfAYiUQwhXmAYu9/JkVNZypqOaOeuDYlcjZDHHlrgym/h2s kppaRG99l4nx6akgJWB0A== Cc: Subject: Re: [patch] Misc warnings found by clang. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2010 22:08:16 -0000 On Monday 14 June 2010 23:22:42 Pawel Worach wrote: > Here is a patch that fixes a couple of "warning: format string is not a > string literal" and a couple of unused/never read variable "len" warnings > in lib/libugidfw. I'm not sure about the intention behind the len assignements in libugidfw - might be just a leftover - but if the idea is to teach a model that "we generally care about the return value of snprintf()", a void cast might be the more protable solution. > http://pes.vlakno.cz/~pwo/clang-warn-fix-head.diff Regards, Max