From owner-svn-ports-head@FreeBSD.ORG  Wed Jan 29 22:48:48 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4451972C;
 Wed, 29 Jan 2014 22:48:48 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 055551EF6;
 Wed, 29 Jan 2014 22:48:48 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id A4793BDC2E;
 Wed, 29 Jan 2014 23:48:46 +0100 (CET)
Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205])
 by prod2.absolight.net (Postfix) with ESMTPA id 813DBBDC24;
 Wed, 29 Jan 2014 23:48:46 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by atuin.in.mat.cc (Postfix) with ESMTP id D5633CD46F4F;
 Wed, 29 Jan 2014 23:48:45 +0100 (CET)
Date: Wed, 29 Jan 2014 23:48:43 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Juergen Lock <nox@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r341790 - head/multimedia/szap-s2
Message-ID: <33CFB80361C43DC17B99E87C@atuin.in.mat.cc>
In-Reply-To: <201401292244.s0TMib46086321@svn.freebsd.org>
References: <201401292244.s0TMib46086321@svn.freebsd.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jan 2014 22:48:48 -0000

+--On 29 janvier 2014 22:44:37 +0000 Juergen Lock <nox@FreeBSD.org> wrote:
| +
| +.include <bsd.port.options.mk>
|  
|  do-install:
|  	(cd ${WRKSRC} && ${INSTALL_PROGRAM} szap-s2 ${STAGEDIR}/${PREFIX}/bin)
| -.if !defined(NOPORTDOCS)
| -	${MKDIR} ${DOCSDIR}
| -	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR})
| +.if ${PORT_OPTIONS:MDOCS}
| +	${MKDIR} ${STAGEDIR}${DOCSDIR}
| +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
|  .endif

Hi,

Could you remove the include of port.options and always install the DOCS
into the staging area ? It would save us parsing bsd.port.mk one time too
many.

Like it says on https://wiki.freebsd.org/ports/StageDir

The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases
when installed files are big enough to cause significant I/O overhead.

Regards,

-- 
Mathieu Arnold