From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 3 07:00:46 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95BE816A4CF for ; Mon, 3 Jan 2005 07:00:46 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6222C43D53 for ; Mon, 3 Jan 2005 07:00:46 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0370kEX002521 for ; Mon, 3 Jan 2005 07:00:46 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0370kVW002520; Mon, 3 Jan 2005 07:00:46 GMT (envelope-from gnats) Resent-Date: Mon, 3 Jan 2005 07:00:46 GMT Resent-Message-Id: <200501030700.j0370kVW002520@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andre Albsmeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7E0A16A4CE for ; Mon, 3 Jan 2005 06:50:24 +0000 (GMT) Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B01A43D1F for ; Mon, 3 Jan 2005 06:50:23 +0000 (GMT) (envelope-from andre.albsmeier@siemens.com) Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.12.6/8.12.6) with ESMTP id j036oMVi000031 for ; Mon, 3 Jan 2005 07:50:22 +0100 Received: from mars.cert.siemens.com (mars.cert.siemens.com [139.25.19.9]) by mail1.siemens.de (8.12.6/8.12.6) with ESMTP id j036oMPQ023161 for ; Mon, 3 Jan 2005 07:50:22 +0100 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7]) mail/cert.mc.pre,v 1.65 2004/10/29 21:53:46 mailadm Exp $) with ESMTP id j036oMto091161 for ; Mon, 3 Jan 2005 07:50:22 +0100 (CET) Received: (from localhost) by curry.mchp.siemens.de (8.13.1/8.13.1) id j036oMYX052397 for FreeBSD-gnats-submit@freebsd.org; Mon, 3 Jan 2005 07:50:22 +0100 (CET) Message-Id: <200501030650.j036oLlr024930@curry.mchp.siemens.de> Date: Mon, 3 Jan 2005 07:50:21 +0100 (CET) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/75739: Intel Etherexpress 10MBit broken since recent commit to fxp driver X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2005 07:00:46 -0000 >Number: 75739 >Category: kern >Synopsis: Intel Etherexpress 10MBit broken since recent commit to fxp driver >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 03 07:00:45 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Andre Albsmeier >Release: FreeBSD 4.11-RC1 i386 >Organization: >Environment: FreeBSD 4.11-RC1 using an Intel Etherexpress 10MBit >Description: This commit: mux 2004-12-28 22:49:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/fxp if_fxp.c Log: Merge if_fxp.c:1.220 from HEAD to RELENG_4: date: 2004/12/20 10:18:21; author: mux; state: Exp; lines: +2 -2 Only try to use the 82503 serial interface for the 82557 chipsets. The datasheet says it is only valid for such chipsets and shouldn't be used with others. This fixes some 82559 based cards which otherwise only work at 10Mbit. broke the Intel Etherexpress 10MBit card which has an INTEL S82557 and a SEEQ NQ80C24 chip on them: fxp1: port 0xb800-0xb81f mem 0xe0800000-0xe08fffff,0xe3800000-0xe3800fff irq 10 at device 11.0 on pci0 fxp1: Ethernet address 00:a0:c9:a9:1d:06 fxp1: MII without any PHY! device_probe_and_attach: fxp1 attach returned 6 >How-To-Repeat: Boot a recent 4.11-RC1 with the above card and try to use it. >Fix: I assume the patch is not correct but it works here: --- if_fxp.c.ORI Fri Dec 31 16:40:32 2004 +++ if_fxp.c Fri Dec 31 17:01:15 2004 @@ -511,7 +511,7 @@ * Determine whether we must use the 503 serial interface. */ fxp_read_eeprom(sc, &data, 6, 1); - if (sc->revision == FXP_REV_82557 && (data & FXP_PHY_DEVICE_MASK) != 0 + if ((sc->revision == 0 || sc->revision == FXP_REV_82557) && (data & FXP_PHY_DEVICE_MASK) != 0 && (data & FXP_PHY_SERIAL_ONLY)) sc->flags |= FXP_FLAG_SERIAL_MEDIA; >Release-Note: >Audit-Trail: >Unformatted: