From owner-svn-ports-head@FreeBSD.ORG Sat May 25 09:02:30 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 24332A8F; Sat, 25 May 2013 09:02:30 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by mx1.freebsd.org (Postfix) with ESMTP id 107557F7; Sat, 25 May 2013 09:02:28 +0000 (UTC) Received: by mail-ee0-f51.google.com with SMTP id e51so3044398eek.24 for ; Sat, 25 May 2013 02:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=kWlsqoS6BNzq2gMFONJmBKfhi/EaSqMmwd6eXE4NcCs=; b=gBF+hynqBBXgbGDbbcsHqkbRxNkqgztaQVJ+ll710skKPNlpsmsMlZAg4allXpAIo5 G23StSC4LrorXq+kN/hn4QSs9OZhnVF/oFBBtAq7ozv/Pnx/wMZrLWIzsdIIkjZAJk4w OTQDZiGNOw+i/4/hjmKw3hQeEbnLZdzeC5f47itFqcGAkpyKGm4bVKWP1O4njexNTCY5 wIUehaHdh5uOrk9aliqX+20+JxNM+rY/xa5rJUhoKRq7bscb2wcmvpV/wYlKBZrJ8jnN +Zc5X2zUjZjUetnSkxmgiJ31aE/KQxbz67PenWxFZsbCk6qCLCeiiH0BMpwWtikCKBg9 gjhQ== X-Received: by 10.14.177.130 with SMTP id d2mr2915359eem.133.1369472547946; Sat, 25 May 2013 02:02:27 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.15.23.76 with HTTP; Sat, 25 May 2013 02:01:57 -0700 (PDT) In-Reply-To: <20130525024425.GC89166@FreeBSD.org> References: <201305232205.r4NM5MSa002349@svn.freebsd.org> <20130524033728.GE48975@FreeBSD.org> <20130525024425.GC89166@FreeBSD.org> From: Chris Rees Date: Sat, 25 May 2013 10:01:57 +0100 X-Google-Sender-Auth: 6-TOGtU7dyRvl9yVl1QNMkSkDTo Message-ID: Subject: Re: svn commit: r318913 - in head/devel/libcfu: . files To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , svn-ports-all@freebsd.org, Eitan Adler , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2013 09:02:30 -0000 On 25 May 2013 03:44, Alexey Dokuchaev wrote: > On Fri, May 24, 2013 at 07:14:09PM +0200, Eitan Adler wrote: >> On 24 May 2013 05:37, Alexey Dokuchaev wrote: >> > On Thu, May 23, 2013 at 10:05:22PM +0000, Chris Rees wrote: >> >> New Revision: 318913 >> >> URL: http://svnweb.freebsd.org/changeset/ports/318913 >> >> >> >> Log: >> >> New versions of clang complain about assigning variables to themselves. >> >> >> >> Let's just remove -Werror and ignore the warnings. >> > >> > Hmm, wouldn't it be better to fix these bugs (judging from commit log it >> > should not be too hard) and send the patch upstream? >> >> I agree fixing these bugs is a good thing. I don't believe that this >> is a function of the ports team though. IMHO disabling warnings is >> the simplest, least intrusive patch that works. > > Good maintainer typically would work with upstream to make sure their > software builds and runs on FreeBSD with little possible special tuning > required. Not just it is "being nice", it also helps us to create and > maintain image of an OS that is worth writing software for. :) > > While I agree that investing time in a large complex patch when simple > workaround is available is a bit too much (unless port maintainer is also > on the upstream devteam), fixing *simple* things such as compiler warnings > is better than throwing -Werror. Yes, however this software hasn't been updated since 2005. I'll consider talking to upstream, but my priority at the time was to just get the stuff building and working-- it was a Thursday night and I had a load of Real Life work to do when I got the failure notification. Chris