From owner-freebsd-ports@FreeBSD.ORG Sun Jul 21 23:22:37 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EF2D1BBB for ; Sun, 21 Jul 2013 23:22:37 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) by mx1.freebsd.org (Postfix) with ESMTP id BA150919 for ; Sun, 21 Jul 2013 23:22:37 +0000 (UTC) Received: from mouf.net (swills@mouf [199.48.129.64]) by mouf.net (8.14.5/8.14.5) with ESMTP id r6LNMQsK063597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 21 Jul 2013 23:22:31 GMT (envelope-from swills@mouf.net) Received: (from swills@localhost) by mouf.net (8.14.5/8.14.5/Submit) id r6LNMPYR063596; Sun, 21 Jul 2013 23:22:25 GMT (envelope-from swills) Date: Sun, 21 Jul 2013 23:22:25 +0000 From: Steve Wills To: Douglas Thrift Subject: Re: FreeBSD Port: rubygem-ohai-6.16.0 Message-ID: <20130721232223.GB59806@mouf.net> References: <51EC34F8.70609@douglasthrift.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51EC34F8.70609@douglasthrift.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Sun, 21 Jul 2013 23:22:32 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net X-Virus-Scanned: clamav-milter 0.97.8 at mouf.net X-Virus-Status: Clean Cc: ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jul 2013 23:22:38 -0000 Thanks, I went ahead and filed a PR for it: http://www.freebsd.org/cgi/query-pr.cgi?pr=180732 We're going to have to wait on a maintainer timeout I think. Steve On Sun, Jul 21, 2013 at 12:22:32PM -0700, Douglas Thrift wrote: > Hello, > > I have attached a patch for Ohai which fixes IP address detection when > there is an interface with no addresses such as ipfw0. I have already > submitted the patch upstream: https://tickets.opscode.com/browse/OHAI-492. > > Thanks! > -- > Douglas William Thrift > > > --- ./lib/ohai/plugins/network.rb.orig 2013-07-20 23:51:57.000000000 -0700 > +++ ./lib/ohai/plugins/network.rb 2013-07-20 23:52:07.000000000 -0700 > @@ -42,6 +42,7 @@ > ipaddresses = [] > # ipaddresses going to hold #{family} ipaddresses and their scope > Mash[network['interfaces']].each do |iface, iface_v| > + next if iface_v.nil? or not iface_v.has_key? 'addresses' > iface_v['addresses'].each do |addr, addr_v| > next if addr_v.nil? or not addr_v.has_key? "family" or addr_v['family'] != family > ipaddresses << { > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"