From owner-freebsd-current@FreeBSD.ORG Fri Jun 30 02:57:50 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 425FB16A415; Fri, 30 Jun 2006 02:57:50 +0000 (UTC) (envelope-from oberman@es.net) Received: from postal3.es.net (postal3.es.net [198.128.3.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7BC643D68; Fri, 30 Jun 2006 02:57:49 +0000 (GMT) (envelope-from oberman@es.net) Received: from ptavv.es.net ([198.128.4.29]) by postal3.es.net (Postal Node 3) with ESMTP (SSL) id IBA74465; Thu, 29 Jun 2006 19:57:42 -0700 Received: from ptavv.es.net (localhost [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 31BCD45047; Thu, 29 Jun 2006 19:57:42 -0700 (PDT) To: Jung-uk Kim In-reply-to: Your message of "Thu, 29 Jun 2006 20:59:45 EDT." <200606292059.47722.jkim@FreeBSD.org> Date: Thu, 29 Jun 2006 19:57:42 -0700 From: "Kevin Oberman" Message-Id: <20060630025742.31BCD45047@ptavv.es.net> Cc: freebsd-current@FreeBSD.org Subject: Re: Unable to build acpi_asus module on current today X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2006 02:57:50 -0000 > From: Jung-uk Kim > Date: Thu, 29 Jun 2006 20:59:45 -0400 > > On Thursday 29 June 2006 07:30 pm, Kevin Oberman wrote: > > Today I tried rebuilding my laptop running current. Building the > > kernel module acpi_asus, the build bombed with the error: > > ===> acpi_asus (all) > > cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE > > -nostdinc -I- > > -I/usr/src/sys/modules/acpi/acpi_asus/../../../contrib/dev/acpica > > -I. -I@ -I@/contrib/altq -finline-limit=8000 --param > > inline-unit-growth=100 --param large-function-growth=1000 > > -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 > > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding > > -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > -fformat-extensions -c /usr/src/sys/modules > > /acpi/acpi_asus/../../../dev/acpi_support/acpi_asus.c > > /usr/src/sys/modules/acpi/acpi_asus/../../../dev/acpi_support/acpi_ > >asus.c: In function `acpi_asus_attach': > > /usr/src/sys/modules/acpi/acpi_asus/../../../dev/acpi_support/acpi_ > >asus.c:584: error: 'for' loop initial declaration used outside C99 > > mode > > > > But this module has not been touched since April and I have built > > all of it many times since then. Several other modules seem to have > > the same problem of declaring a variable in a for statement. > > > > I moved the declaration to its own statement before the "for" and > > it compiles fine. > > > > Did some compiler default recently change? I have no compile > > options on my make.conf. > > Yes: > > http://docs.freebsd.org/cgi/mid.cgi?200606292115.k5TLFQch022605 > > A quick fix: > > Index: sys/conf/kmod.mk > =================================================================== > RCS file: /home/ncvs/src/sys/conf/kmod.mk,v > retrieving revision 1.208 > diff -u -r1.208 kmod.mk > --- sys/conf/kmod.mk 27 May 2006 16:32:05 -0000 1.208 > +++ sys/conf/kmod.mk 30 Jun 2006 00:57:37 -0000 > @@ -85,8 +85,10 @@ > .if ${CC} == "icc" > NOSTDINC= -X > .else > +C_DIALECT= -std=c99 > NOSTDINC= -nostdinc > .endif > +CFLAGS+= ${C_DIALECT} > CFLAGS:= ${CFLAGS:N-I*} ${NOSTDINC} -I- ${INCLMAGIC} ${CFLAGS:M-I*} > .if defined(KERNBUILDDIR) > CFLAGS+= -DHAVE_KERNEL_OPTION_HEADERS -include ${KERNBUILDDIR}/opt_global.h Jung-uk, Thanks you so much. I might have found this, but it would have taken a long time! Looks like this needs to be fixed in the base system or all of the modules need to be checked and fixed to compile with the new flags. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634