From owner-freebsd-ports@FreeBSD.ORG Fri Jan 29 13:38:42 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC313106566B; Fri, 29 Jan 2010 13:38:42 +0000 (UTC) (envelope-from stephen@missouri.edu) Received: from cauchy.math.missouri.edu (cauchy.math.missouri.edu [128.206.184.213]) by mx1.freebsd.org (Postfix) with ESMTP id B5ED28FC16; Fri, 29 Jan 2010 13:38:42 +0000 (UTC) Received: from laptop3.gateway.2wire.net (cauchy.math.missouri.edu [128.206.184.213]) by cauchy.math.missouri.edu (8.14.3/8.14.3) with ESMTP id o0TDce5q097561; Fri, 29 Jan 2010 07:38:40 -0600 (CST) (envelope-from stephen@missouri.edu) Message-ID: <4B62E4E0.6090006@missouri.edu> Date: Fri, 29 Jan 2010 07:38:40 -0600 From: Stephen Montgomery-Smith User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.7) Gecko/20100112 Firefox MIME-Version: 1.0 To: Ion-Mihai Tetcu References: <4B61E988.1000801@missouri.edu><4B620382.7070902@FreeBSD.org><20100128224601.GA64692@comcast.net> <20100129125203.1273ed4f@it.buh.tecnik93.com> In-Reply-To: <20100129125203.1273ed4f@it.buh.tecnik93.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Charlie Kester , "freebsd-ports@freebsd.org" Subject: Re: patch upgrade for port committers? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2010 13:38:43 -0000 Ion-Mihai Tetcu wrote: > On Thu, 28 Jan 2010 17:01:44 -0600 (CST) > Stephen Montgomery-Smith wrote: >> Also, I have taken to using shar files instead of diff's when >> creating new files. > > Don't please, it makes committer's work harder. > And update to a port should be a diff. Preferably a cvs diff -u. > > I am thinking of something like this: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/142360 I separated the diff and the shar files - diff for what is already existing, and shar for new files. Are you saying that you would prefer if I had done a single diff with "diff -urN"? Part of the reason I started to do this is because, even when I had clear messages like "there are new files XXX and YYY" they would still get forgotten by committers.