From owner-svn-ports-head@FreeBSD.ORG Sat May 25 11:38:37 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 155FA80A; Sat, 25 May 2013 11:38:37 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) by mx1.freebsd.org (Postfix) with ESMTP id 2958AD3B; Sat, 25 May 2013 11:38:36 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hq7so393114wib.16 for ; Sat, 25 May 2013 04:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=akweZJKBwIs0U3vP48bTEF57CBBSbZakFoSOactWN2g=; b=KjBfri0EM9ScurAMhkTm/s4lU00t8ThFqcigso5oSGbzRUeX34rsRbzsANaOOOqRGg zEb8c4iMD/VP3L1JoNYgAiw2X4aOVvv1o/rntpT3pi4zJ9VD8WKhpz2jfa2Y2LSpjS/w tIxfZrVObTFhfMNUwISTq2EyPJYI6UUDeNh3bs/2tedW5nBVwrvajTuJWpmcnteCDQtj e8x7ge8KjF/2yBTSVqpcasu5Yn14RgYldfPWbJoiCTHr8ORlfZnVapqrzCHLCyNxjUsY M9Epbsdkurxm/Eo3xECRHeI1KGpM1npPOp7MzR3qNG+FeZIg9QoWw3nF5dw3G4Ixq1KW 0ITg== X-Received: by 10.180.206.205 with SMTP id lq13mr2116907wic.42.1369481915223; Sat, 25 May 2013 04:38:35 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id k10sm4579676wia.4.2013.05.25.04.38.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 25 May 2013 04:38:34 -0700 (PDT) Sender: Baptiste Daroussin Date: Sat, 25 May 2013 13:38:31 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r318993 - in head: archivers/libcabinet archivers/libcabinet/files devel/libpdel devel/libxalloc finance/libstocks games/libshhcards games/libshhcards/files japanese/ming math/linpack w... Message-ID: <20130525113831.GI96836@ithaqua.etoilebsd.net> References: <201305241635.r4OGZVa7094499@svn.freebsd.org> <20130525024802.GD89166@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rPKw41Fi6dB0MaHy" Content-Disposition: inline In-Reply-To: <20130525024802.GD89166@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2013 11:38:37 -0000 --rPKw41Fi6dB0MaHy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2013 at 02:48:02AM +0000, Alexey Dokuchaev wrote: > On Fri, May 24, 2013 at 04:35:31PM +0000, Baptiste Daroussin wrote: > > New Revision: 318993 > > URL: http://svnweb.freebsd.org/changeset/ports/318993 > >=20 > > Log: > > Do not let system make.conf inpact the port's makefile > > This fixes build on current > >=20 > > @@ -13,6 +13,7 @@ USE_LDCONFIG=3D yes > > =20 > > SRCFILE=3D ${WRKSRC}/listcab.cpp > > PROGFILE=3D ${SRCFILE:S/.cpp$//} > > +MAKE_ENV=3D WITHOUT_PROFILE=3Dyes __MAKE_CONF=3D/dev/null SRCCONF=3D/d= ev/null >=20 > This looks bogus. Can you shed some light on what exactly breaks these > ports? Can they be fixed without introducing cryptic constructs in their > ports Makefiles? I'd volunteer to fix (when -current gets stable enough > to be feasible for remote upgrade; I don't want to get unbootable box). >=20 > ./danfe I know this looks bogus, but imho this isn't the port should have control o= n own and what things are being built and installed, not a third party file. in that case what is fixed is that if a user set WITH_PROFILE in src.conf a= lib will end up creating and installing a _p.a file, we have the same for .symb= ols, and probably more things. btw: no need to be in current to experience those plist breakage we can still offer the user the same kind of control pn the build process, = but we should to it via the port itself. regards, Bapt --rPKw41Fi6dB0MaHy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGgorcACgkQ8kTtMUmk6Ew35QCfSNFHWyHSoAjoYV4WsdA244ad QAEAnR1Kge5bIfclDaEpMh+jCnOua7Uo =MQuN -----END PGP SIGNATURE----- --rPKw41Fi6dB0MaHy--