From owner-freebsd-current Tue Nov 23 22:57:58 1999 Delivered-To: freebsd-current@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 4F16914CE6 for ; Tue, 23 Nov 1999 22:57:39 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 0FDFF1CC7; Wed, 24 Nov 1999 14:57:37 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Dan Nelson Cc: Lyndon Nerenberg , David Malone , Brian Somers , Poul-Henning Kamp , Forrest Aldrich , freebsd-current@FreeBSD.ORG, brian@hak.lan.Awfulhak.org Subject: bogus kern_proc.c change (Re: ps on 4.0-current) In-Reply-To: Message from Dan Nelson of "Tue, 23 Nov 1999 18:37:34 CST." <19991123183733.A21142@dan.emsphone.com> Date: Wed, 24 Nov 1999 14:57:37 +0800 From: Peter Wemm Message-Id: <19991124065737.0FDFF1CC7@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Dan Nelson wrote: > In the last episode (Nov 23), Lyndon Nerenberg said: > > After you verify that this change isn't going to break things that > > assume they can see the *argv list via ps(1). I.e. lightning bolts > > that do 'kill -MUMBLE `ps -ax|grep foo`'. Which may not be elegant > > style, but sometimes is the only workable solution. > > That won't be affected, because anyone that has kill rights to the > process will also see the full processname. Now that I think about it, > I can't come up with a case where this is really bad. If you're doing > ps'es with intent to kill arbitrary processes (in the name of debugging > or whatever), you're probably already root. It's this bogus change to kern/kern_proc.c. If you back this out it should work as expected. @@ -631,7 +633,7 @@ if (!p) return (0); - if (!PRISON_CHECK(curproc, p)) + if (p_trespass(curproc, p)) return (0); if (req->newptr && curproc != p) Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message