From owner-freebsd-ports@FreeBSD.ORG Fri Jan 29 13:47:40 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF48D1065670 for ; Fri, 29 Jan 2010 13:47:40 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from worf.ds9.tecnik93.com (worf.ds9.tecnik93.com [81.196.207.130]) by mx1.freebsd.org (Postfix) with ESMTP id 16A8B8FC1F for ; Fri, 29 Jan 2010 13:47:39 +0000 (UTC) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by worf.ds9.tecnik93.com (Postfix) with ESMTPSA id E2F1522C50B7; Fri, 29 Jan 2010 15:47:38 +0200 (EET) Date: Fri, 29 Jan 2010 15:47:37 +0200 From: Ion-Mihai Tetcu To: Stephen Montgomery-Smith Message-ID: <20100129154737.637b4c5f@it.buh.tecnik93.com> In-Reply-To: <4B62E4E0.6090006@missouri.edu> References: <4B61E988.1000801@missouri.edu> <4B620382.7070902@FreeBSD.org> <20100128224601.GA64692@comcast.net> <20100129125203.1273ed4f@it.buh.tecnik93.com> <4B62E4E0.6090006@missouri.edu> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.18.6; amd64-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/1pP/.iE=oNvZOG54/B+c8ZZ"; protocol="application/pgp-signature" Cc: Charlie Kester , "freebsd-ports@freebsd.org" Subject: Re: patch upgrade for port committers? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2010 13:47:40 -0000 --Sig_/1pP/.iE=oNvZOG54/B+c8ZZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 29 Jan 2010 07:38:40 -0600 Stephen Montgomery-Smith wrote: > Ion-Mihai Tetcu wrote: > > On Thu, 28 Jan 2010 17:01:44 -0600 (CST) > > Stephen Montgomery-Smith wrote: >=20 > >> Also, I have taken to using shar files instead of diff's when > >> creating new files. > > > > Don't please, it makes committer's work harder. > > And update to a port should be a diff. Preferably a cvs diff -u. > > > > >=20 > I am thinking of something like this: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/142360 >=20 > I separated the diff and the shar files - diff for what is already=20 > existing, and shar for new files. >=20 > Are you saying that you would prefer if I had done a single diff with=20 > "diff -urN"? I would prefer this: http://people.tecnik93.com/~itetcu/FreeBSD/How-to-submit-a-diff.txt > Part of the reason I started to do this is because, even when I had=20 > clear messages like "there are new files XXX and YYY" they would > still get forgotten by committers. Yes, we're all only humans. A single diff for me means: cd ~/tmp/PCVS pcvs ci portname cd portname /usr/ports/Tools/scripts/getpr pr_no /usr/ports/Tools/scripts/prpatch ... Anything else means more. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/1pP/.iE=oNvZOG54/B+c8ZZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkti5voACgkQJ7GIuiH/oeX3cACferwc4hZbGeFqnNN7AjPKI0OL 6tkAnjux4veEOeYUzDqH/zqSxqUX3jFK =4k1v -----END PGP SIGNATURE----- --Sig_/1pP/.iE=oNvZOG54/B+c8ZZ--