From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:37:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A012B16A41F; Tue, 18 Oct 2005 15:37:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44EF543D45; Tue, 18 Oct 2005 15:37:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IFbFvP092005; Tue, 18 Oct 2005 08:37:15 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IFbFLK092004; Tue, 18 Oct 2005 08:37:15 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 08:37:15 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051018153715.GE84920@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <1129576130.1152.30.camel@leguin> <200510171554.46682.jhb@freebsd.org> <200510171642.26719.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171642.26719.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:37:16 -0000 On Mon, Oct 17, 2005 at 04:42:24PM -0400, Jung-uk Kim wrote: > The patch is attached. Please review. It would be nice if you'd wait more than a few hours before committing something when you've asked for a review of it... especially when the discussion is still on-going. The patch you committed added nothing. Unless you think the user does not understand the meaning of the word "dual". What is missing is the number of _packages_ (populated sockets) in the system. CPU: Dual Core AMD Opteron(tm) Processor 280 (2394.49-MHz K8-class CPU) .. Found 2 sockets with 2 cores per package seems a more informative output for the user. Quick prototype: Index: sys/amd64/amd64/identcpu.c =================================================================== RCS file: /home/ncvs/src/sys/amd64/amd64/identcpu.c,v retrieving revision 1.140 diff -u -u -1 -r1.140 identcpu.c --- sys/amd64/amd64/identcpu.c 17 Oct 2005 23:23:20 -0000 1.140 +++ sys/amd64/amd64/identcpu.c 18 Oct 2005 15:30:16 -0000 @@ -51,2 +51,3 @@ #include +#include @@ -360,3 +361,4 @@ if (cmp > 1) - printf("\n Cores per package: %d", cmp); + printf("\n Found %d sockets with %d cores per package", + mp_ncpus / cmp, cmp); if ((htt / cmp) > 1)