From owner-freebsd-current@FreeBSD.ORG Wed Jul 10 05:39:17 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8B6B6C6B for ; Wed, 10 Jul 2013 05:39:17 +0000 (UTC) (envelope-from gljennjohn@googlemail.com) Received: from mail-bk0-x233.google.com (mail-bk0-x233.google.com [IPv6:2a00:1450:4008:c01::233]) by mx1.freebsd.org (Postfix) with ESMTP id 1F55B1465 for ; Wed, 10 Jul 2013 05:39:16 +0000 (UTC) Received: by mail-bk0-f51.google.com with SMTP id ji1so2666223bkc.38 for ; Tue, 09 Jul 2013 22:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :x-mailer:mime-version:content-type:content-transfer-encoding; bh=YbWl6esx5Yl9w5Q7B43p+7G4g4OJbhh66touyGkks8M=; b=fpl2aLr1wLPWUmonsE5FJRtsiSC/VixE1YIK1pNLQshom4C2IsABqjOZ0HDvUECf9V V1pyH5zIu+3ZpXPYPrFpxq00qg4izL2X05CZ+65KuJR70T3W9DvDH6fIrZqW4yk/p8m4 81iP20elZCsB67CiPyBGGVyt7IcFxyWnTAhiqLQuqElRzIE8c1l44tnOhu2VT3BIBUtV rncnoEcMdnyoSAXs/nLzk+ik4TUal6STNBGndEAF4qUeJId+xvYh4S0+3Y+UhFtRSt9x B6E9txxSKN/u2MEYpfLpxGFVuogo8vzWl8RPF9g0BvX7c7M/l6aWRJ3MkqHVKHUCWghM CeCQ== X-Received: by 10.205.10.200 with SMTP id pb8mr4780831bkb.0.1373434756041; Tue, 09 Jul 2013 22:39:16 -0700 (PDT) Received: from ernst.home (p578E11E1.dip0.t-ipconnect.de. [87.142.17.225]) by mx.google.com with ESMTPSA id ch16sm6571617bkb.17.2013.07.09.22.39.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 09 Jul 2013 22:39:15 -0700 (PDT) Date: Wed, 10 Jul 2013 07:39:12 +0200 From: Gary Jennejohn To: Alexander Leidinger Subject: Re: kernel compile broken in latest HEAD Message-ID: <20130710073912.54fedfc8@ernst.home> In-Reply-To: <20130709223356.000005ad@unknown> References: <20130709173233.275469b4@ernst.home> <20130709223356.000005ad@unknown> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.17; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: gljennjohn@googlemail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 05:39:17 -0000 On Tue, 9 Jul 2013 22:33:56 +0200 Alexander Leidinger wrote: > On Tue, 9 Jul 2013 17:32:33 +0200 > Gary Jennejohn wrote: > > > I just saw this breakage while compiling a kernel on HEAD updated > > minutes ago: > > Is your cc a gcc or clang? My one is clang and I didn't get build > errors when I tested the commit. I was told there are those errors with > gcc. My question in the corresponding thread is so far unanswered. > gcc > Here's what I wrote as a reference: > ---snip--- > Does someone know what this is supposed to result in? > > I would assume as the unions are unnamed and no variable is declared > inside the struct with it, that the size of the struct is the same as > not having those unions inside the structs. > > If this is correct I would assume the correct fix would be to #if-0 > them out. > ---snip--- > > > These line numbers all point at nameless unions. > > > > Seems to me that a union needs a name, otherwise one cannot > > access its contents. > > > > I simply named them all x to get the kernel to compile, which > > succeeded. > > Did you name it x ("union x {...};"), or did you declare a variable > x with it ("union {...} x;")? > the latter -- Gary Jennejohn