From owner-freebsd-current@FreeBSD.ORG Wed Jun 8 17:56:41 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CF031065675 for ; Wed, 8 Jun 2011 17:56:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 642DA8FC1C for ; Wed, 8 Jun 2011 17:56:41 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 196EA46B37; Wed, 8 Jun 2011 13:56:41 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A234A8A02A; Wed, 8 Jun 2011 13:56:40 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 8 Jun 2011 13:56:39 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201106071035.37662.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106081356.39221.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Wed, 08 Jun 2011 13:56:40 -0400 (EDT) Cc: "deeptech71@gmail.com" Subject: Re: pcib allocation failure X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2011 17:56:41 -0000 On Wednesday, June 08, 2011 11:20:17 am deeptech71@gmail.com wrote: > On Tue, Jun 7, 2011 at 4:35 PM, John Baldwin wrote: > found-> vendor=0x1002, dev=0x4170, revid=0x00 > domain=0, bus=1, slot=0, func=1 > class=03-80-00, hdrtype=0x00, mfdev=0 > cmdreg=0x0007, statreg=0x02b0, cachelnsz=4 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x00 (0 ns) > powerspec 2 supports D0 D1 D2 D3 current D0 > map[10]: type Prefetchable Memory, range 32, base 0xe0000000, size 28, enabled > pcib1: attempting to grow prefetch window for (0xe0000000-0xefffffff,0x10000000) > pcib1: attempting to grow memory window for (0xe0000000-0xefffffff,0x10000000) Odd, I'm not sure why this failed. Hmm, it seems this was always failing for you though in the older dmesg's though. Hmmm, can you revert all your changes to pci_pci.c and try just this change: Index: pci_pci.c =================================================================== --- pci_pci.c (revision 222863) +++ pci_pci.c (working copy) @@ -953,7 +975,7 @@ pcib_grow_window(struct pcib_softc *sc, struct pci * ok, ensure it is properly aligned for this window. * Also check for overflow. */ - if (back <= end && start_free <= back) { + if (back <= end + 1 && start_free <= back) { if (bootverbose) printf("\tback candidate range: %#lx-%#lx\n", start_free, back); -- John Baldwin