From owner-freebsd-virtualization@FreeBSD.ORG  Mon Nov 11 16:00:49 2013
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 96B69A2D
 for <freebsd-virtualization@freebsd.org>; Mon, 11 Nov 2013 16:00:49 +0000 (UTC)
 (envelope-from roger.pau@citrix.com)
Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D97CA21EF
 for <freebsd-virtualization@freebsd.org>; Mon, 11 Nov 2013 16:00:48 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.93,678,1378857600"; d="scan'208";a="73191888"
Received: from accessns.citrite.net (HELO FTLPEX01CL01.citrite.net)
 ([10.9.154.239])
 by FTLPIPO01.CITRIX.COM with ESMTP; 11 Nov 2013 16:00:42 +0000
Received: from [IPv6:::1] (10.80.16.47) by smtprelay.citrix.com (10.13.107.78)
 with Microsoft SMTP Server id 14.2.342.4;
 Mon, 11 Nov 2013 11:00:40 -0500
Message-ID: <5280FF27.1090405@citrix.com>
Date: Mon, 11 Nov 2013 17:00:39 +0100
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Sergey Kandaurov <pluknet@gmail.com>, Pavel Timofeev <timp87@gmail.com>
Subject: Re: Running `sysctl -a` causes crash (Hyper-V)
References: <CAAoTqfvrdKH6BC=KrpWLgBKDjx402oTt_bp1TnV_Z3FC1if88A@mail.gmail.com>
 <CAE-mSOLKgk_h10mUPLuMXHgPfYJMEog_FFdyZvEoAOXMh=rbfg@mail.gmail.com>
 <CAAoTqfu9NFuVFYnLFo+LG7_kXd+AaxEPTm4nCKETzWvje7=fyA@mail.gmail.com>
 <CAE-mSOLeMHkh7gKLZPYcyu3GdJKqN4hAMBgEf5TwMUxB4nQ7zA@mail.gmail.com>
 <CAAoTqftAbsDNUiCv4QRnNfamf61dPhJ+WAzgfVVL4QMe9qHxcA@mail.gmail.com>
 <CAE-mSOLszJLfHBgmSTaUH5+5dTe23XLUFbp-nhfPpz2UVWMCJQ@mail.gmail.com>
In-Reply-To: <CAE-mSOLszJLfHBgmSTaUH5+5dTe23XLUFbp-nhfPpz2UVWMCJQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Cc: "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2013 16:00:49 -0000

On 11/11/13 15:31, Sergey Kandaurov wrote:
> On 11 November 2013 18:13, Pavel Timofeev <timp87@gmail.com> wrote:
>> [...]
>> (kgdb) p vm_guest
>> $1 = 3
>> Current language:  auto; currently minimal
>> (kgdb)
>>
> 
> What if you try this change?
> 
> Index: sys/kern/subr_param.c
> ===================================================================
> --- sys/kern/subr_param.c    (revision 257695)
> +++ sys/kern/subr_param.c    (working copy)
> @@ -153,6 +153,7 @@
>      "none",
>      "generic",
>      "xen",
> +    "hv",
>      NULL
>  };

This is my fault, I've added VM_GUEST_HV to the guest type enum without
knowing there was another array in a completely different file that
contained a description for those values.

If you (or someone else) are going to commit this change, I would
recommend adding a BIG comment in sys/systm.h above the declaration of
VM_GUEST explaining that if you add a new guest type there you also need
to add a description in subr_param.c, this will probably prevent
something like this happening again.