From owner-freebsd-current Wed Apr 25 18:41:37 2001 Delivered-To: freebsd-current@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 5379237B422 for ; Wed, 25 Apr 2001 18:41:34 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f3Q1fXM64909 for ; Wed, 25 Apr 2001 18:41:33 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 50363380A; Wed, 25 Apr 2001 18:41:33 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Alfred Perlstein Cc: Terry Lambert , current@FreeBSD.ORG, terry@lambert.org Subject: Re: PATCH to make maxfiles, maxfiles per proc boot-time tunable In-Reply-To: <20010424122508.U1790@fw.wintelcom.net> Date: Wed, 25 Apr 2001 18:41:33 -0700 From: Peter Wemm Message-Id: <20010426014133.50363380A@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > * Terry Lambert [010424 11:59] wrote: > > It seems to me that these things are not boot-time tunable, and > > should be (really, they should be runtime tunable, but there > > are some nasty pageable region allocations for networking that > > appear to require contiguous regions for no good reason which I > > can discern). That means that the best we can do right now is > > boot-time, so here it is: > > This looks good except that ncallout is still based on MAXFILES, > without this being fixed I think people might get bitten by > raising the tuneable too high then being unable to allocate > enough callouts. Can you take a look at this and make sure there's > nothing else using MAXFILES like that? The problem is that param.c is *not* included in gensetdefs scope. Therefore linker set entries (ie: SYSINIT etc) are not executed. TUNABLE* entries in param.c are simply not called or used. SYSTEM_OBJS= locore.o setdef0.o vnode_if.o ${OBJS} ioconf.o param.o config.o \ setdef1.o hack.So ... setdef0.c setdef1.c setdefs.h: ${OBJS} @gensetdefs ${OBJS} param.o is not included in ${OBJS}. I dont see how this patch can work as-is. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message