From owner-svn-src-all@freebsd.org Sat Jun 4 17:19:27 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0122AB69BE1; Sat, 4 Jun 2016 17:19:27 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C65411AFC; Sat, 4 Jun 2016 17:19:26 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u54HJQlp056334; Sat, 4 Jun 2016 17:19:26 GMT (envelope-from arybchik@FreeBSD.org) Received: (from arybchik@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u54HJQlN056333; Sat, 4 Jun 2016 17:19:26 GMT (envelope-from arybchik@FreeBSD.org) Message-Id: <201606041719.u54HJQlN056333@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: arybchik set sender to arybchik@FreeBSD.org using -f From: Andrew Rybchenko Date: Sat, 4 Jun 2016 17:19:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r301397 - stable/10/sys/dev/sfxge/common X-SVN-Group: stable-10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2016 17:19:27 -0000 Author: arybchik Date: Sat Jun 4 17:19:25 2016 New Revision: 301397 URL: https://svnweb.freebsd.org/changeset/base/301397 Log: MFC r300845 sfxge(4): cope with lint for EFX_SET_OWORD_BIT() with const bit arg Found by lint on illumos. Submitted by: Garrett D'Amore Sponsored by: Solarflare Communications, Inc. Modified: stable/10/sys/dev/sfxge/common/siena_mac.c Directory Properties: stable/10/ (props changed) Modified: stable/10/sys/dev/sfxge/common/siena_mac.c ============================================================================== --- stable/10/sys/dev/sfxge/common/siena_mac.c Sat Jun 4 17:18:35 2016 (r301396) +++ stable/10/sys/dev/sfxge/common/siena_mac.c Sat Jun 4 17:19:25 2016 (r301397) @@ -158,8 +158,17 @@ siena_mac_reconfigure( * so we always add bit 0xff to the mask (bit 0x7f in the * second octword). */ - if (epp->ep_brdcst) + if (epp->ep_brdcst) { + /* + * NOTE: due to constant folding, some of this evaluates + * to null expressions, giving E_EXPR_NULL_EFFECT during + * lint on Illumos. No good way to fix this without + * explicit coding the individual word/bit setting. + * So just suppress lint for this one line. + */ + /* LINTED */ EFX_SET_OWORD_BIT(multicast_hash[1], 0x7f); + } (void) memset(payload, 0, sizeof (payload)); req.emr_cmd = MC_CMD_SET_MCAST_HASH;