From owner-svn-src-all@FreeBSD.ORG  Tue Sep  7 21:38:38 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 85C9610656A4;
	Tue,  7 Sep 2010 21:38:37 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Date: Tue, 7 Sep 2010 17:38:17 -0400
User-Agent: KMail/1.6.2
References: <201009060734.o867YWH8022846@svn.freebsd.org>
	<201009061128.40344.jhb@freebsd.org>
In-Reply-To: <201009061128.40344.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201009071738.22600.jkim@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Andriy Gapon <avg@freebsd.org>
Subject: Re: svn commit: r212251 - head/sys/dev/acpi_support
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2010 21:38:38 -0000

On Monday 06 September 2010 11:28 am, John Baldwin wrote:
> On Monday 06 September 2010 03:34:32 am Andriy Gapon wrote:
> > Author: avg
> > Date: Mon Sep  6 07:34:32 2010
> > New Revision: 212251
> > URL: http://svn.freebsd.org/changeset/base/212251
> >
> > Log:
> >   acpi_hp: fix bus attachment code
> >
> >   - add identify method to create driver's own device_t
> >   - successfully probe only driver's own device_t instead of any
> > device_t - (ab)use device order to hopefully be probed/attached
> > after acpi_wmi
>
> Perhaps this should be a child of acpi_wmi0 instead?  That would
> fix the ordering issue as well as remove the need to avoid "real"
> ACPI devices in the attach routine.

+1

Jung-uk Kim