From owner-cvs-all Fri Jul 23 1:11:48 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id C68A9156C0; Fri, 23 Jul 1999 01:11:41 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id KAA33653; Fri, 23 Jul 1999 10:10:58 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Mike Smith Cc: Peter Jeremy , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, jkh@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall tcpip.c In-reply-to: Your message of "Thu, 22 Jul 1999 17:30:24 PDT." <199907230030.RAA03011@dingo.cdrom.com> Date: Fri, 23 Jul 1999 10:10:58 +0200 Message-ID: <33651.932717458@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk I would advocate the ether_input API. I have never heard of a 3rd party ethernet driver, and considering the number of changes we introduce between 3.x and 4.x anyway, driver compatibility is already pretty much shot anyway, so I think we should fix the API to do it "right" rather than fight for a compatibility which is at best of only marginal advantage to anybody. Poul-Henning In message <199907230030.RAA03011@dingo.cdrom.com>, Mike Smith writes: >> That is really a deficiency of our ethernet layer (on my todo-list >> way down there...) Each ethernet driver shouldn't have to know >> as much as it does about the input path for packets, or for that >> matter if bpf is there or not. > >The basic problem here is that bpf et. al. want the whole datagram, >while ether_input wants it broken up into the header and body. > >There are two approaches we can take here; either we change ether_input >to take the raw packet (alters the driver API) or we shim bpf to >reconstruct the packet. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message