From owner-freebsd-hackers  Thu May 11 16:54:48 1995
Return-Path: hackers-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id QAA19818
          for hackers-outgoing; Thu, 11 May 1995 16:54:48 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.1])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id QAA19812
          for <hackers@freebsd.org>; Thu, 11 May 1995 16:54:46 -0700
Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id QAA08019; Thu, 11 May 1995 16:57:47 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id QAA00302; Thu, 11 May 1995 16:54:45 -0700
Message-Id: <199505112354.QAA00302@corbin.Root.COM>
To: terry@cs.weber.edu (Terry Lambert)
cc: hackers@FreeBSD.org
Subject: Re: Something silly in ufs/ufs/ufs_lookup.c 
In-reply-to: Your message of "Thu, 11 May 95 16:22:28 MDT."
             <9505112222.AA00978@cs.weber.edu> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Thu, 11 May 1995 16:54:45 -0700
Sender: hackers-owner@FreeBSD.org
Precedence: bulk

>In ufs_checkpath(), the int rootino is assigned the value ROOTINO,
>which is never modified, only compared against.
>
>Shouldn't the references to rootino be deleted and replaced with the
>manifest constant ROOTINO?

   Yes, it should. If it were defined at the top level, the answer would be
different...but it's not.

-DG