From owner-cvs-all@FreeBSD.ORG Mon May 26 16:18:17 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85A831065670; Mon, 26 May 2008 16:18:17 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 3AA498FC23; Mon, 26 May 2008 16:18:16 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from tirith.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTP id 331BE1CC0D2; Mon, 26 May 2008 18:18:15 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id 4DF4011422; Mon, 26 May 2008 18:18:14 +0200 (CEST) Date: Mon, 26 May 2008 18:18:13 +0200 From: Henrik Brix Andersen To: Joe Marcus Clarke Message-ID: <20080526161813.GA72695@tirith.brixandersen.dk> Mail-Followup-To: Joe Marcus Clarke , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200805251720.m4PHKtRD026886@repoman.freebsd.org> <20080525215334.GA66430@tirith.brixandersen.dk> <1211754054.69646.13.camel@shumai.marcuscom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline In-Reply-To: <1211754054.69646.13.camel@shumai.marcuscom.com> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.17 (2007-11-01) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils Makefile ports/sysutils/conky Makefile ports/sysutils/conky-awesome Makefile pkg-descr ports/sysutils/conky-awesome/files patch-src_conky.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2008 16:18:17 -0000 --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 25, 2008 at 06:20:54PM -0400, Joe Marcus Clarke wrote: > On Sun, 2008-05-25 at 23:53 +0200, Henrik Brix Andersen wrote: > > On Sun, May 25, 2008 at 05:20:55PM +0000, Joe Marcus Clarke wrote: > > > marcus 2008-05-25 17:20:54 UTC > > >=20 > > > FreeBSD ports repository > > >=20 > > > Modified files: > > > sysutils Makefile=20 > > > sysutils/conky Makefile=20 > > > sysutils/conky-awesome Makefile pkg-descr=20 > > > Added files: > > > sysutils/conky-awesome/files patch-src_conky.c=20 > > > Log: > > > Add sysutils/conky-awesome after a repocopy from sysutils/conky. > > > Conky-awesome is the conky X-based system monitor ported to the awe= some > > > window manager. > > > =20 > > > Submitted by: adamw > > > Conky diffs approved by: novel > >=20 > > Does this really warrant a port of its own? Couldn't it just be a KNOB > > in sysutils/conky? >=20 > This kind of changes (requiring new patches and a new pkg-descr) Patches? The only patch I see is this one-liner, which adds an extra line break to a printf() argument? http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/conky-awesome/files/pa= tch-src_conky.c?rev=3D1.1&content-type=3Dtext/plain That seems simple enough to be included in the regular conky port? (Why is that patch even needed for 'awesome'?) Brix --=20 Henrik Brix Andersen --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) Comment: GnuPG signed iEYEARECAAYFAkg64sUACgkQv+Q4flTiePjCiACeMl4wAgwYeKGQyixkXaGIk0f5 ZNAAnjfzdPNpmldtu5J4ShIGWmmnFIJE =65nc -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--