From owner-freebsd-current@FreeBSD.ORG Sun Dec 2 06:14:38 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9B9A16A418; Sun, 2 Dec 2007 06:14:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 9128013C442; Sun, 2 Dec 2007 06:14:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Iyhgh-000D0f-ML; Sun, 02 Dec 2007 07:48:20 +0200 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id lB25mG3p081772; Sun, 2 Dec 2007 07:48:16 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id lB25mGPO081771; Sun, 2 Dec 2007 07:48:16 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 2 Dec 2007 07:48:16 +0200 From: Kostik Belousov To: Carl Shapiro Message-ID: <20071202054815.GQ83121@deviant.kiev.zoral.com.ua> References: <4dcb5abd0711290226u69105089ya10526519e5cc12d@mail.gmail.com> <20071129112824.GD83121@deviant.kiev.zoral.com.ua> <4dcb5abd0711292235k2bc2af86t45f7268d429c03ad@mail.gmail.com> <20071130152631.GJ83121@deviant.kiev.zoral.com.ua> <4dcb5abd0712012042m6e6cd00br3c9e72c97f047ee5@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l4+/aJnPlhOv5JVj" Content-Disposition: inline In-Reply-To: <4dcb5abd0712012042m6e6cd00br3c9e72c97f047ee5@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: d3dfc5a0b247ea81d48b6a940fe6235f X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1838 [Dec 01 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: freebsd-current@freebsd.org, davidxu@freebsd.org Subject: Re: Serious compatibility breakage in -current. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2007 06:14:39 -0000 --l4+/aJnPlhOv5JVj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 01, 2007 at 08:42:56PM -0800, Carl Shapiro wrote: > On Nov 30, 2007 7:26 AM, Kostik Belousov wrote: > > The patch I posted was enough for CMUCL to survive the gc. >=20 > The SIGBUS handler in CMUCL compares the value of si_code to > BUS_PAGE_FAULT. If these values do not compare equal, the signal is > not interpreted by the garbage collector. For the record, your > original patch did not fill the si_code value with BUS_PAGE_FAULT and > so it was not enough. Is this some new code ? I did tested it on CLUCL-19d compiled for RELENG_6. Also, the sigbus_handler() from lisp/FreeBSD-os.c rev 1.12 does not contain the check, it seems (that describes why it worked for me). >=20 > > Patch below shall implement it, and be MFCed to RELENG_7. The change to > > crtbrand.c shall be MFCed to RELENG_6 (and, possibly, RELENG_5). Patch > > was lightly tested on i386, and compile tested on amd64. > > Please, give it a run. >=20 > I applied your patch to my 7.0-BETA3 sources and my test programs now > behave as expected. Notably, the si_code value is always correct. > Thanks! I will put the patch into the tree ASAP, subject to coordination with re@ and portmgr@. Could you, please, describe what was tested in more details ? Did you run the CMUCL (and sbcl) with the patch ? If yes, could you, please, show the file(1) output on the bin/lisp and bin/sbcl binary ? --l4+/aJnPlhOv5JVj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHUkcfC3+MBN1Mb4gRAg8YAJ9kQedrtdtjo0J4Vmzf0FocKodwkwCfa+1+ ZlnYymp8CoQFw8UjL8irLFQ= =T5L7 -----END PGP SIGNATURE----- --l4+/aJnPlhOv5JVj--