From owner-freebsd-hackers Thu May 11 17:02:14 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA19967 for hackers-outgoing; Thu, 11 May 1995 17:02:14 -0700 Received: from ref.tfs.com (ref.tfs.com [140.145.254.251]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id RAA19961 for ; Thu, 11 May 1995 17:02:14 -0700 Received: (from phk@localhost) by ref.tfs.com (8.6.8/8.6.6) id RAA00989; Thu, 11 May 1995 17:02:02 -0700 From: Poul-Henning Kamp Message-Id: <199505120002.RAA00989@ref.tfs.com> Subject: Re: Something silly in ufs/ufs/ufs_lookup.c To: davidg@Root.COM Date: Thu, 11 May 1995 17:02:02 -0700 (PDT) Cc: terry@cs.weber.edu, hackers@FreeBSD.org In-Reply-To: <199505112354.QAA00302@corbin.Root.COM> from "David Greenman" at May 11, 95 04:54:45 pm Content-Type: text Content-Length: 731 Sender: hackers-owner@FreeBSD.org Precedence: bulk > >In ufs_checkpath(), the int rootino is assigned the value ROOTINO, > >which is never modified, only compared against. > > > >Shouldn't the references to rootino be deleted and replaced with the > >manifest constant ROOTINO? > > Yes, it should. If it were defined at the top level, the answer would be > different...but it's not. I thought this was the beginning of support for mount /dev/sd2e:/some/dir /mnt where you mount something different than the root of the filesystem... I can live without that of course (I always have had to :-) -- Poul-Henning Kamp -- TRW Financial Systems, Inc. 'All relevant people are pertinent' && 'All rude people are impertinent' => 'no rude people are relevant'