From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 9 11:59:43 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CC831065672; Mon, 9 Nov 2009 11:59:43 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from poseidon.ceid.upatras.gr (poseidon.ceid.upatras.gr [150.140.141.169]) by mx1.freebsd.org (Postfix) with ESMTP id A2CBB8FC15; Mon, 9 Nov 2009 11:59:42 +0000 (UTC) Received: from mail.ceid.upatras.gr (unknown [10.1.0.143]) by poseidon.ceid.upatras.gr (Postfix) with ESMTP id B0E89EB47AF; Mon, 9 Nov 2009 13:37:31 +0200 (EET) Received: from localhost (europa.ceid.upatras.gr [127.0.0.1]) by mail.ceid.upatras.gr (Postfix) with ESMTP id A0BDD452B4; Mon, 9 Nov 2009 13:37:31 +0200 (EET) X-Virus-Scanned: amavisd-new at ceid.upatras.gr Received: from mail.ceid.upatras.gr ([127.0.0.1]) by localhost (europa.ceid.upatras.gr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OCcJObyEIXLp; Mon, 9 Nov 2009 13:37:31 +0200 (EET) Received: from kobe.laptop (ppp-94-64-211-25.home.otenet.gr [94.64.211.25]) by mail.ceid.upatras.gr (Postfix) with ESMTP id 571C7451B2; Mon, 9 Nov 2009 13:37:31 +0200 (EET) Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.3/8.14.3) with ESMTP id nA9BbUK9003585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Nov 2009 13:37:30 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.3/8.14.3/Submit) id nA9BbTq0003584; Mon, 9 Nov 2009 13:37:29 +0200 (EET) (envelope-from keramida@freebsd.org) From: Giorgos Keramidas To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= In-Reply-To: <86hbt4j9v8.fsf@ds4.des.no> ("Dag-Erling =?iso-8859-1?Q?Sm=F8?= =?iso-8859-1?Q?rgrav=22's?= message of "Mon, 09 Nov 2009 11:00:43 +0100") References: <87y6mg17y2.fsf@kobe.laptop> <86hbt4j9v8.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (berkeley-unix) Date: Mon, 09 Nov 2009 13:37:22 +0200 Message-ID: <87vdhkgc99.fsf@kobe.laptop> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: freebsd-hackers@freebsd.org, Alexander Best , Gabor Kovesdan Subject: Re: [patch] burncd: honour for envar SPEED X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 11:59:43 -0000 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, 09 Nov 2009 11:00:43 +0100, Dag-Erling Sm=F8rgrav wrot= e: > Giorgos Keramidas writes: >> atoi() doesn't really have error checking and it does not necessarily >> affect `errno'. > > man 3 expand_number I know, but thanks. In this case, expand_number's logic for parsing possible SI suffixes is not useful and may be slightly confusing. I'm not sure what CDROM_SPEED=3D'4m' would mean for burncd's -s option, for example. > And please don't call it SPEED or WRITE_SPEED or anything generic; call > it BURNCD_SPEED or CDROM_BURN_SPEED or something unambiguous. The envar > used to specify the device is called CDROM, not DEVICE. Good point. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkr3/vgACgkQ1g+UGjGGA7Y2+ACdFLfjx1Nm0icvPhGlwa107q+r O0gAn3ORD0ATJtV9gYZMQpVCk7onZEYl =g4qT -----END PGP SIGNATURE----- --=-=-=--