From owner-cvs-src@FreeBSD.ORG  Sun Apr  6 17:00:08 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E626B1065670;
	Sun,  6 Apr 2008 17:00:07 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 8430B8FC12;
	Sun,  6 Apr 2008 17:00:07 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 15DCB41C756;
	Sun,  6 Apr 2008 19:00:06 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id QstItcWSCU3i; Sun,  6 Apr 2008 19:00:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id B4AFA41C752; Sun,  6 Apr 2008 19:00:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 8CACB44487F;
	Sun,  6 Apr 2008 16:55:56 +0000 (UTC)
Date: Sun, 6 Apr 2008 16:55:56 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: Brooks Davis <brooks@FreeBSD.org>
In-Reply-To: <200803280757.m2S7vqvN037009@repoman.freebsd.org>
Message-ID: <20080406165513.N66744@maildrop.int.zabbadoz.net>
References: <200803280757.m2S7vqvN037009@repoman.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d ppp src/share/man/man5 rc.conf.5
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Apr 2008 17:00:08 -0000

On Fri, 28 Mar 2008, Brooks Davis wrote:

> brooks      2008-03-28 07:57:52 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    etc/rc.d             ppp
>    share/man/man5       rc.conf.5
>  Log:
>  Add support for hardwiring ppp sessions to particular devices with new
>  per-profile variables of the form ppp_<profile>_unit.  No ppp_unit
>  variable is supported since tying the same unit to more than one profile
>  won't work.
>
>  PR:             conf/122127
>  MFC after:      1 week

There is a bug in there:

+	# Check for hard wired unit
+	eval _ppp_unit=\$ppp_${_ppp_profile_cleaned}_unit
+	if [ -n "_ppp_unit" ]; then

                 ^^^^^^^^^^^  should ${_ppp_unit}

+		_ppp_unit="-unit${_ppp_unit}"
+	fi
+	rc_flags="$rc_flags $_ppp_unit"



>  Revision  Changes    Path
>  1.18      +8 -1      src/etc/rc.d/ppp
>  1.337     +9 -1      src/share/man/man5/rc.conf.5

-- 
Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
Software is harder than hardware  so better get it right the first time.